Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bump BraveRewards library to 1.21.x #3404

Closed
kylehickinson opened this issue Mar 11, 2021 · 1 comment · Fixed by #3405
Closed

Bump BraveRewards library to 1.21.x #3404

kylehickinson opened this issue Mar 11, 2021 · 1 comment · Fixed by #3405

Comments

@kylehickinson
Copy link
Collaborator

No description provided.

@LaurenWags
Copy link
Member

LaurenWags commented Mar 24, 2021

Verified passed on iPad mini with iOS 13 running 1.24 (21.3.24.11)

Verified test plan from #3405 (comment)

Sanity check rewards
  1. Clean profile
  • Installed 1.24 (21.3.24.11)
  • Confirmed Rewards not enabled by default
  • Enabled Rewards
  • Navigated to various sites, confirmed sites known to be verified are reflected as such from panel
  • Confirmed auto contribute was performed successfully
  1. Upgrade profile (Rewards not enabled prior to upgrade)
  • Installed 1.23.1
  • Confirmed Rewards not enabled
  • Upgraded to 1.24
  • Confirmed Rewards not enabled after upgrade
  1. Upgrade profile (Rewards enabled prior to upgrade)
  • Installed 1.23.1
  • Enabled Rewards
  • Upgraded to 1.24
  • Confirmed Rewards still enabled after upgrade
Sanity check ads
  1. Clean profile
  • Installed 1.24 (21.3.24.11)
  • Confirmed Rewards not enabled by default
  • Confirmed ads not shown when Rewards not enabled
  • Enabled Rewards
  • Confirmed able to see page classification in logs
  • Confirmed NTP views recorded in logs
  • Confirmed able to see click, view, dismiss events in logs
  • Encountered and logged reduced ads delivery on iOS #3458
  1. Upgrade profile (Rewards not enabled prior to upgrade)
  • Installed 1.23.1
  • Confirmed Rewards not enabled
  • Upgraded to 1.24
  • Confirmed Rewards not enabled after upgrade
  • Confirmed ads not received after upgrade
  1. Upgrade profile (Rewards enabled prior to upgrade)
  • Installed 1.23.1
  • Enabled Rewards
  • Upgraded to 1.24
  • Confirmed rewards still enabled after upgrade
  • Confirmed ads received after upgrade
  1. Clean profile
  • Installed 1.24 (21.3.25.18)
  • Enabled Rewards
  • Confirmed able to see click, view, dismiss, landed events in logs
  • Confirmed tokens redeemed with the server successfully
  • Confirmed expected number of ads viewed is shown in "Rewards Debug Menu"
  • Confirmed expected balance is shown in "Rewards Debug Menu"
  • Confirmed ads shown at 2per hour cadence
Sanity check sync
  1. Clean profile
  • Install 1.24 (21.3.25.18)
  • Confirmed able to join sync chain using code words
  • Confirmed able to join sync chain using QR code
  • Confirmed able to start a sync chain and have laptop join
  • Confirmed bookmarks from prior to sync were added to laptop
  • Confirmed bookmarks from prior to sync on laptop were added to iOS device
  • Confirmed bookmarks added post sync to iOS device were synced to laptop
  • Confirmed bookmarks added post sync to laptop were synced to iOS device
  1. Upgrade profile
  • Install 1.23.1
  • Join a sync chain and have bookmarks synced
  • Upgrade to 1.24
  • Confirm sync chain retained after upgrade
  • Confirm newly created bookmarks on iOS sync to laptop
  • Confirm newly created bookmarks on laptop sync to iOS

Verified passed on iPhone 7 with iOS 14 running 1.24 (21.3.31.15)

Verified the Brave Rewards/Ads and Sync sections of the manual test run: #3473

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.