Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add ability to save PDF opened in Brave via share sheet menu #3323

Closed
iccub opened this issue Feb 17, 2021 · 9 comments · Fixed by #5053
Closed

Add ability to save PDF opened in Brave via share sheet menu #3323

iccub opened this issue Feb 17, 2021 · 9 comments · Fixed by #5053

Comments

@iccub
Copy link
Contributor

iccub commented Feb 17, 2021

Description:

Safari has this option:

IMG_C9DABC041D5F-1

Steps to Reproduce

  1. Open a pdf
  2. Open share menu

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Reported here
https://community.brave.com/t/how-to-download-a-pdf-file-on-iphone/207624

@balintbarna
Copy link

I'd say this is more of a bug, there's no way to download a PDF in brave. And there isn't even a share to safari option, so I have to go through the steps to open the same PDF in safari and then download it from there.

@RonanCodes
Copy link

RonanCodes commented Sep 3, 2021

In order to save the pdf locally I have to copy paste the link into Safari.

@mia1024
Copy link

mia1024 commented Dec 10, 2021

This is especially problematic for any PDF that requires user login. So now to download the PDF I have to go to the same website on Safari, login to the website, go through 2FA, and then paste the same link just to get the PDF file. In addition, the print menu option doesn't seem to do anything.

@berndwa
Copy link

berndwa commented Feb 9, 2022

Any news about this?

@talondnb
Copy link

Looks like sharing to Dropbox app works so that’s a workaround I’m using for the moment.

@cuba cuba self-assigned this Mar 2, 2022
cuba added a commit that referenced this issue Mar 4, 2022
Fix #3323: Revert back to standard share sheet elements based on URL

fix comments
@iccub iccub added this to the 1.37 milestone Mar 4, 2022
@berndwa
Copy link

berndwa commented Mar 4, 2022

Why is this closed? PDF-Download still not works on iOS Brave or am I missing st?

@iccub
Copy link
Contributor Author

iccub commented Mar 4, 2022

@berndwa we close tickets once the code to fix it has been merged and is ready for the next release.
We hope to land it in Brave iOS 1.37

@berndwa
Copy link

berndwa commented Mar 4, 2022

Allright, thank you =)

@berndwa we close tickets once the code to fix it has been merged and is ready for the next release.

We hope to land it in Brave iOS 1.37

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 30, 2022

Verification Completed using version 1.37 (22.3.29.15)

Devices:
iPhone 12 Pro | iOS 15.4
iPhone X | iOS 14.4.2
iPad (7th Gen) | iOS 15.2.1

Test Plan: #5053 (comment)

  • Create PDF share sheet for reader mode
  • Create PDF share sheet for regular mode
  • Share site on reader mode
  • Share site on regular mode
  • Test sharing brave shield stats
  • Test sharing large PDF
  • Test emailing pdf
mobile 1 mobile 2
IMG_2559 IMG_2560

Tablet
IMG_0225

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.