Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

"Sources & Settings" under intro card sometimes uses grey text #3290

Closed
kjozwiak opened this issue Feb 11, 2021 · 2 comments · Fixed by #3407
Closed

"Sources & Settings" under intro card sometimes uses grey text #3290

kjozwiak opened this issue Feb 11, 2021 · 2 comments · Fixed by #3407

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 11, 2021

Description:

Sometimes the Sources & Settings string uses grey text rather than the expected white text. When this happens, it's harder to read as the background of the intro card is grey as well.

Steps to Reproduce

I don't really have STR as I've only seen this happen twice. But it usually happens after opening an article from Brave Today. @brave/legacy_qa if you run into this and can reliably reproduce, please update STR 👍

Actual result:

image

Expected result:

image

Reproduces how often: [Easily reproduced, Intermittent Issue]

I've only seen this happen a few times so it seems rare but

Brave Version:

  • Reproduced using 1.23 (21.2.10.18)

Device details:

  • iPhone 11 running iOS 14.4 using 1.23 (21.2.10.18) - Reproduced
  • iPad Air (3rd Gen) running iOS 14.4 using 1.23 (21.2.10.18) - Reproduced

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @karenkliu @anthonypkeane @srirambv @bsclifton @iccub @kylehickinson @soner-yuksel

@kjozwiak
Copy link
Member Author

I didn't add this into 1.23 as I don't think it's a blocker/something we need to fix ASAP. It's also pretty rare and users won't see it once they've closed the intro card. Plus, I don't really have reliable STR. @anthonypkeane @bsclifton please add it into 1.23 if you feel differently 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.24(21.3.24.11)

iPhone 7+ (iOS 14.4) iPhone XR (iOS 13.5) iPad Pro (iOS 12.4.1)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants