Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Startup database crash #3169

Closed
iccub opened this issue Jan 5, 2021 · 0 comments · Fixed by #3170
Closed

Startup database crash #3169

iccub opened this issue Jan 5, 2021 · 0 comments · Fixed by #3170
Assignees
@iccub
Labels
bug Epic: Performance QA/No release-notes/include
Milestone
1.22.2

Comments

@iccub
Copy link
Contributor

iccub commented Jan 5, 2021

Description:

Zrzut ekranu 2021-01-5 o 10 37 37

Steps to Reproduce

  1. Hard to reproduce it's a race condition

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.23 milestone Jan 5, 2021
@iccub iccub self-assigned this Jan 5, 2021
iccub added a commit that referenced this issue Jan 5, 2021
@iccub
Fix #3169: Database race condition crash at startup.
0798714 
`DataController` internals were initialized after first DB operations,
`Migration.launchMigrations` were called first, on a background thread
which can result in race conditions.
@iccub iccub closed this as completed Jan 6, 2021
@iccub iccub reopened this Jan 6, 2021
@iccub iccub mentioned this issue Jan 6, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Jan 6, 2021
@iccub
Fix #3169: Database race condition crash at startup. (#3170)
55b2857 
`DataController` internals were initialized after first DB operations,
`Migration.launchMigrations` were called first, on a background thread
which can result in race conditions.
@iccub iccub modified the milestones: 1.23, 1.22.2 Jan 13, 2021
iccub added a commit that referenced this issue Jan 13, 2021
@iccub
Fix #3169: Database race condition crash at startup. (#3170)
f28460e 
`DataController` internals were initialized after first DB operations,
`Migration.launchMigrations` were called first, on a background thread
which can result in race conditions.
@kjozwiak kjozwiak mentioned this issue Jan 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug Epic: Performance QA/No release-notes/include
Projects
None yet
Milestone
1.22.2
Development

Successfully merging a pull request may close this issue.

Fix #3169: Database race condition crash at startup. brave/brave-ios
2 participants
@kjozwiak @iccub