Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rewards text update #2829

Closed
anthonypkeane opened this issue Aug 21, 2020 · 3 comments · Fixed by #2835
Closed

Rewards text update #2829

anthonypkeane opened this issue Aug 21, 2020 · 3 comments · Fixed by #2835
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.20

Comments

@anthonypkeane
Copy link

Description:

Please update the text for Rewards as shown in this figma design

https://www.figma.com/file/lu4tsEpIvnNpovX5O2BfNh/Mobile-Rewards-Settings?node-id=48%3A256

Please also remove the reference to USD

cc @mandar-brave for reference as this is rewards related
@anthonypkeane anthonypkeane added this to the 1.20 milestone Aug 21, 2020
@iccub iccub modified the milestones: 1.21, 1.20 Aug 21, 2020
@iccub iccub added blocked: needs info Needs further information before work can commence enhancement release-notes/exclude and removed blocked: needs info Needs further information before work can commence labels Aug 21, 2020
@iccub iccub assigned iccub and kylehickinson and unassigned kylehickinson and iccub Aug 21, 2020
@anthonypkeane anthonypkeane added the blocked: needs info Needs further information before work can commence label Aug 21, 2020
@anthonypkeane
Copy link
Author

@bradleyrichter to remove the "blocked" label once he has finalized the copy

kylehickinson added a commit that referenced this issue Aug 24, 2020
@kylehickinson
Fix #2829: Update Rewards Copy
d07d72d
@kylehickinson kylehickinson mentioned this issue Aug 24, 2020
Merged
7 tasks
@iccub iccub added blocked: needs info Needs further information before work can commence and removed blocked: needs info Needs further information before work can commence labels Aug 24, 2020
kylehickinson added a commit that referenced this issue Aug 24, 2020
@kylehickinson
Fix #2829: Update Rewards Copy
9156130
@kylehickinson kylehickinson removed the blocked: needs info Needs further information before work can commence label Aug 25, 2020
@kylehickinson
Copy link
Collaborator

Copy was finalized by @bradleyrichter

iccub pushed a commit that referenced this issue Aug 25, 2020
@kylehickinson
Fix #2829: Update Rewards Copy (#2835)
2f2c149
iccub pushed a commit that referenced this issue Aug 25, 2020
@kylehickinson @iccub
Fix #2829: Update Rewards Copy (#2835)
2148af6
kylehickinson added a commit that referenced this issue Sep 1, 2020
@kylehickinson
Ref #2829: Remove missed copy in rewards summary
793cc5c
@kylehickinson kylehickinson mentioned this issue Sep 1, 2020
Merged
7 tasks
iccub pushed a commit that referenced this issue Sep 1, 2020
@kylehickinson
Ref #2829: Remove missed copy in rewards summary (#2853)
92ace86
iccub pushed a commit that referenced this issue Sep 1, 2020
@kylehickinson @iccub
Ref #2829: Remove missed copy in rewards summary (#2853)
cd0000f
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14 running 1.20(20.09.11.20)

  • Verified all USD references are removed from the rewards panel
image image image image image
image image image image image

Verification passed on iPad Pro with iOS 14 running 1.20(20.09.11.20)

  • Verified all USD references are removed from the rewards panel
image image image image image
image image image image image

Verification passed on iPhone XR with iOS 14 running 1.20(20.09.11.20)

  • Verified all USD references are removed from the rewards panel
image image image image image
image image image image image

@kjozwiak kjozwiak mentioned this issue Sep 17, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.20
Development

Successfully merging a pull request may close this issue.

Fix #2829: Update Rewards Copy brave/brave-ios
4 participants
@kylehickinson @iccub @anthonypkeane @srirambv