Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add http/https URL scheme handlers #2784

Closed
kylehickinson opened this issue Aug 5, 2020 · 1 comment · Fixed by #2777
Closed

Add http/https URL scheme handlers #2784

kylehickinson opened this issue Aug 5, 2020 · 1 comment · Fixed by #2777
Assignees
Labels
Milestone

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Aug 5, 2020

Test Plan

  • Disable Safari
    • Go to Settings.app > Screen Time > Content & Privacy Restrictions
    • Turn on Content & Privacy Restrictions
    • Go to Allowed Apps
    • Toggle Safari off
  • Go to an app such as Notes, Mail, etc. that opens an app with Safari and not in an in-app webview, and click on a http/https link
  • The link should open in Brave (if you haven't done this before you will get a prompt to open the link in Brave first)
  • In Brave, Enable PBO or switch to private browsing mode
  • Repeat open link step
  • Verify it opens the link in a private tab
@srirambv
Copy link
Contributor

srirambv commented Aug 6, 2020

Verification passed on iPhone 7+ with iOS 13.6 running 1.19.2(20.08.5.18)

  • Verified clicking a link from notes asks for permission to open in Brave
  • Verified if Brave is set to PBO only then opening links opens in a private tab
  • Verified if Brave is in normal mode but have private tabs open, opening a link via other app launches it in private tab and not in normal tab.

  • Verification passed on iPhone XR with iOS 13.6 running 1.19.2(20.08.5.18)

  • Verified clicking a https/http link from notes asks for permission to open in Brave
  • Verified if Brave is set to PBO only then opening links opens in a private tab
  • Verified if Brave is in normal mode but have private tabs open, opening a link via other app launches it in private tab and not in normal tab.

  • Verification passed on iPad Pro with iOS 13.6 running 1.19.2(20.08.5.18)

  • Verified clicking a https/http link from notes asks for permission to open in Brave
  • Verified if Brave is set to PBO only then opening links opens in a private tab
  • Verified if Brave is in normal mode but have private tabs open, opening a link via other app launches it in private tab and not in normal tab.
  • Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Labels
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    3 participants