Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Temporary disable the Sync UI until Sync V2 #2718

Closed
anthonypkeane opened this issue Jul 14, 2020 · 2 comments · Fixed by #2741
Closed

Temporary disable the Sync UI until Sync V2 #2718

anthonypkeane opened this issue Jul 14, 2020 · 2 comments · Fixed by #2741
Assignees
@iccub
Labels
Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.19.1

Comments

@anthonypkeane
Copy link

Description:

Temporary disable the Sync UI until Sync V2

@jsecretan can you confirm? WDYT?
@anthonypkeane anthonypkeane added blocked: needs info Needs further information before work can commence QA/Yes labels Jul 14, 2020
@anthonypkeane anthonypkeane added this to the 1.19 milestone Jul 14, 2020
@iccub iccub self-assigned this Jul 15, 2020
@anthonypkeane anthonypkeane modified the milestones: 1.19, 1.20 Jul 15, 2020
@jsecretan
Copy link

Yes, please do, thanks for bringing this up @anthonypkeane. We should also get up our warning infobar ASAP.

@iccub iccub modified the milestones: 1.20, 1.19.1 Jul 27, 2020
iccub added a commit that referenced this issue Jul 27, 2020
@iccub
Fix #2718: Remove sync v1.
06c0da5
iccub added a commit that referenced this issue Jul 27, 2020
@iccub
Fix #2718: Remove sync v1.
c3166ce
iccub added a commit that referenced this issue Jul 29, 2020
@iccub
Fix #2718: Remove sync v1.
e272bfa
iccub added a commit that referenced this issue Jul 29, 2020
@iccub
Fix #2718: Remove sync v1.
c0f5d65
iccub added a commit that referenced this issue Jul 29, 2020
@iccub
Fix #2718: Remove sync v1.
16c19e2
@iccub iccub mentioned this issue Jul 29, 2020
Merged
7 tasks
iccub added a commit that referenced this issue Jul 29, 2020
@iccub
Fix #2718: Remove sync v1.
ef9fb60
@srirambv
Copy link
Contributor

srirambv commented Jul 31, 2020 •
edited
Loading

Verification passed on iPhone XR with iOS 13.5 running 1.19.1(20.07.30.16)

No sync user

  • Verified upgrading from 1.19 to 1.19.1 without sync chain there is no alert message is shown
  • Verified upon upgrade sync option is hidden in settings
Before After

Sync user

  • Verified alert message is shown when upgrading from 1.19 with a sync chain

  • Verified no bookmarks are sync'd after upgrading to 1.19

  • Verified adding or removing bookmarks from iOS device doesn't affect/add/remove bookmarks on the sync chain it was part of

Verification passed on iPhone 7+ with iOS 13.6 running 1.19.1(20.07.30.16)

No sync user

  • Verified upgrading from 1.19 to 1.19.1 without sync chain there is no alert message is shown
  • Verified upon upgrade sync option is hidden in settings
Before After

Sync user

  • Verified alert message is shown when upgrading from 1.19 with a sync chain

  • Verified no bookmarks are sync'd after upgrading to 1.19

  • Verified adding or removing bookmarks from iOS device doesn't affect/add/remove bookmarks on the sync chain it was part of

Verification passed on iPad Pro with iOS 12.4.1 running 1.19.1(20.07.30.16)

No sync user

  • Verified upgrading from 1.19 to 1.19.1 without sync chain there is no alert message is shown
  • Verified upon upgrade sync option is hidden in settings
Before After

Sync user

  • Verified alert message is shown when upgrading from 1.19 with a sync chain

  • Verified no bookmarks are sync'd after upgrading to 1.19

  • Verified adding or removing bookmarks from iOS device doesn't affect/add/remove bookmarks on the sync chain it was part of

Verification passed on iPad Pro with iOS 13.6.1 running 1.19.1(20.07.30.16)

No sync user

  • Verified upgrading from 1.19 to 1.19.1 without sync chain there is no alert message is shown
  • Verified upon upgrade sync option is hidden in settings
Before After

Sync user

  • Verified alert message is shown when upgrading from 1.19 with a sync chain

  • Verified no bookmarks are sync'd after upgrading to 1.19

  • Verified adding or removing bookmarks from iOS device doesn't affect/add/remove bookmarks on the sync chain it was part of

@srirambv srirambv mentioned this issue Aug 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.19.1
Development

Successfully merging a pull request may close this issue.

Fix #2718: Remove sync v1. brave/brave-ios
4 participants
@jsecretan @iccub @anthonypkeane @srirambv