Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Favicon transparency check crash #2697

Closed
iccub opened this issue Jul 6, 2020 · 1 comment · Fixed by #2701
Closed

Favicon transparency check crash #2697

iccub opened this issue Jul 6, 2020 · 1 comment · Fixed by #2701
Assignees
@kylehickinson
Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.18.1

Comments

@iccub
Copy link
Contributor

iccub commented Jul 6, 2020

Description:

Zrzut ekranu 2020-07-6 o 12 29 21

Steps to Reproduce

Hard to repro, intermittent crash.

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:
1.18

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@iccub iccub added this to the 1.18.1 milestone Jul 6, 2020
kylehickinson added a commit that referenced this issue Jul 6, 2020
@kylehickinson
Fix #2697: Use correct icon size during edge loop for scaled image data
7fcf5f5 
Also:
- Adds a check for if the icon passed is non-zero in both axis
- Dispatches completion blocks within the global thread on main queue because the function is now static and not private
@kylehickinson kylehickinson mentioned this issue Jul 6, 2020
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jul 6, 2020
@kylehickinson
Fix #2697: Use correct icon size during edge loop for scaled image data
d8cfa48 
Also:
- Adds a check for if the icon passed is non-zero in both axis
- Dispatches completion blocks within the global thread on main queue because the function is now static and not private
kylehickinson added a commit that referenced this issue Jul 6, 2020
@kylehickinson
Fix #2697: Use correct icon size during edge loop for scaled image data
c86d33f 
Also:
- Adds a check for if the icon passed is non-zero in both axis
- Dispatches completion blocks within the global thread on main queue because the function is now static and not private
iccub pushed a commit that referenced this issue Jul 6, 2020
@kylehickinson
Fix #2697: Use correct icon size during edge loop for scaled image da…
705fd00 
…ta (#2701)

Also:
- Adds a check for if the icon passed is non-zero in both axis
- Dispatches completion blocks within the global thread on main queue because the function is now static and not private
@iccub iccub added QA/Yes and removed QA/No labels Jul 6, 2020
iccub pushed a commit that referenced this issue Jul 6, 2020
@kylehickinson @iccub
Fix #2697: Use correct icon size during edge loop for scaled image da…
167b756 
…ta (#2701)

Also:
- Adds a check for if the icon passed is non-zero in both axis
- Dispatches completion blocks within the global thread on main queue because the function is now static and not private
@kjozwiak
Copy link
Member

kjozwiak commented Jul 7, 2020 •
edited
Loading

Verification PASSED on 1.18.1 (20.07.06.15) using a iPad Mini 4 running iOS 12.4.1. As per #2701 (comment), went through the following cases:

Verification passed on iPhone XR with iOS 13.5 running 1.18(20.07.06.15)

  • Verified no crash when Add bookmark sheet is loaded
  • Verified websites load favicons correctly on pages
  • Verified default favourites favicon is loaded correctly
  • Verified favicons are shown correctly on tab tray
  • Verified adding bookmarks on both normal and private tabs and there was no crash

@srirambv srirambv mentioned this issue Jul 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug crash QA Pass - iPad QA Pass - iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.1
Development

Successfully merging a pull request may close this issue.

Fix #2697: Use correct icon size during edge loop for scaled image data brave/brave-ios
4 participants
@kylehickinson @kjozwiak @iccub @srirambv