Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Text is not visible when editing a favourite/bookmark in dark mode #2644

Closed
srirambv opened this issue Jun 18, 2020 · 4 comments · Fixed by #3029
Closed

Text is not visible when editing a favourite/bookmark in dark mode #2644

srirambv opened this issue Jun 18, 2020 · 4 comments · Fixed by #3029

Comments

@srirambv
Copy link
Contributor

Description:

Text is not visible when editing a favourite/bookmark on iPad in dark mode

Steps to Reproduce

  1. Install 1.18
  2. Open a new tab and edit the favourite/bookmark
  3. Text is not visible

Actual result:
image

Expected result:
Should be visible

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.18(20.06.16.08)

Device details:
iPad (iOS 12) - Yes
iPhone 6 (iOS 12) - Yes
iPhone XR(iOS 13.5) - No
iPhone 7+(iOS 13.5.1) - No
iPad Pro (iOS 13) - No

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

@srirambv srirambv added this to the 1.18 milestone Jun 18, 2020
@srirambv srirambv changed the title Text is not visible when editing a favourite/bookmark on iPad in dark mode Text is not visible when editing a favourite/bookmark in dark mode Jun 18, 2020
@kylehickinson
Copy link
Collaborator

@srirambv Is this a regression or just a bug? You marked it as 1.18 milestone, is this a release blocker then?

@srirambv
Copy link
Contributor Author

Actually this is not a regression. Seems to be there on current release as well so will move it out of milestone

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Verification PASSED on iPad Air (3rd Gen) on iOS 14.3 using the following build:

1.23 (21.1.28.17)
Normal Tab Private Tab
IMG_0181 IMG_0182

Verification PASSED on iPad Mini 4 on iOS 13.7 using the following build:

1.23 (21.1.28.17)
Normal Tab Private Tab
IMG_0433 IMG_0434

Verification PASSED on iPhone 11 on iOS 14.4 using the following build:

1.23 (21.1.28.17)
Normal Tab Private Tab
IMG_3521 IMG_3522

Verification PASSED on iPhone 6+ on iOS 12.4.1 using the following build:

1.23 (21.1.28.17)
Normal Tab Private Tab
IMG_0092 IMG_0093

@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

@iccub @soner-yuksel looks like this still hasn't been fixed. Text still appears really light when editing bookmarks/favourites. Created #3250 as this one already has a PR associated with it. Also adding the release-notes/include as this fixes an issue that's already in release.

iccub added a commit that referenced this issue Feb 3, 2021
soner-yuksel pushed a commit that referenced this issue Feb 3, 2021
iccub added a commit that referenced this issue Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.