DDG onboarding modal appears every time when creating/switching tabs in PB

[kjozwiak]

Description:

The DDG modal keeps being displayed whenever switching or creating new tabs under PB. Assuming this regressed due to #2350.

Steps to Reproduce

1. install 1.15 (20.03.04.18) from TF
2. once installed, launch 1.15 (20.03.04.18) and skip onboarding
3. switch into PB and you'll notice the DDG modal for the first time (expected)
4. load a website in the original tab and create a new tab (DDG appears again)
5. repeat the above step several times and you'll notice that the DDG modal appears every time
6. switch between tabs, you'll notice the DDG modal appearing every time

Actual result:

Example of the issue occurring: https://youtu.be/OF7pLU02bAk

Expected result:

DDG onboarding modal should only be displayed once when initially opening PB

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version:

• 1.15 (20.03.04.18)

Device details:

• iPhone 11 running iOS 13.3.1 using 1.15 (20.03.04.18) - Reproduced
• iPhone 6s+ running iOS 12.4.1 using 1.15 (20.03.04.18) - Reproduced
• iPad Air 3rd Gen running iOS 13.3.1 using 1.15 (20.03.04.18) - Reproduced
• iPad Mini 4 running iOS 12.4.1 using 1.15 (20.03.04.18) - Reproduced

Website problems only:

• did you check with Brave Shields down? N/A
• did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

CCing @brave/legacy_qa @jhreis @anthonypkeane

[kjozwiak]

Verification PASSED on iPhone 11 running iOS 13.3.1 using 1.15 (20.03.05.13):

• verified that the STR outlined under DDG onboarding modal appears every time when creating/switching tabs in PB #2391 (comment) have been addressed/fixed
• ensured that the DDG modal is being displayed when DDG isn't the default search engine when launching PB for the first time
• ensured the following when DDG has already been set as the default search engine
  • ensured that the DDG modal doesn't appear when opening PB for the first time
  • ensured that the DDG modal doesn't appear when opening new PB tabs
  • ensured that the DDG modal doesn't appear when switching between PB tabs
  • ensured that the DDG modal doesn't appear when closing/re-opening PB mode
• ensured that switching from DDG --> Google while in PB only displays the DDG modal once
  • ensured that selecting Yes switches the search engine from Google --> DDG and doesn't display the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and displays the Learn about private search with DuckDuckGo button via the NTP
• ensured that tapping on the Learn about private search with DuckDuckGo button via NTP displays the modal
  • ensured that selecting Yes switches the search engine from Google --> DDG (PB only) and remove the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and keeps displaying the Learn about private search with DuckDuckGo button via the NTP

---

Verification PASSED on iPhone 6s+ running iOS 12.4.1 using 1.15 (20.03.05.13):

• verified that the STR outlined under DDG onboarding modal appears every time when creating/switching tabs in PB #2391 (comment) have been addressed/fixed
• ensured that the DDG modal is being displayed when DDG isn't the default search engine when launching PB for the first time
• ensured the following when DDG has already been set as the default search engine
  • ensured that the DDG modal doesn't appear when opening PB for the first time
  • ensured that the DDG modal doesn't appear when opening new PB tabs
  • ensured that the DDG modal doesn't appear when switching between PB tabs
  • ensured that the DDG modal doesn't appear when closing/re-opening PB mode
• ensured that switching from DDG --> Google while in PB only displays the DDG modal once
  • ensured that selecting Yes switches the search engine from Google --> DDG and doesn't display the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and displays the Learn about private search with DuckDuckGo button via the NTP
• ensured that tapping on the Learn about private search with DuckDuckGo button via NTP displays the modal
  • ensured that selecting Yes switches the search engine from Google --> DDG (PB only) and remove the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and keeps displaying the Learn about private search with DuckDuckGo button via the NTP

---

Verification PASSED on iPad mini running iOS 13 using 1.15 (20.03.05.14):

• verified that the STR outlined under DDG onboarding modal appears every time when creating/switching tabs in PB #2391 (comment) have been addressed/fixed
• ensured that the DDG modal is being displayed when DDG isn't the default search engine when launching PB for the first time
• ensured the following when DDG has already been set as the default search engine
  • ensured that the DDG modal doesn't appear when opening PB for the first time
  • ensured that the DDG modal doesn't appear when opening new PB tabs
  • ensured that the DDG modal doesn't appear when switching between PB tabs
  • ensured that the DDG modal doesn't appear when closing/re-opening PB mode
• ensured that switching from DDG --> Google while in PB only displays the DDG modal once
  • ensured that selecting Yes switches the search engine from Google --> DDG and doesn't display the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and displays the Learn about private search with DuckDuckGo button via the NTP
• ensured that tapping on the Learn about private search with DuckDuckGo button via NTP displays the modal
  • ensured that selecting Yes switches the search engine from Google --> DDG (PB only) and remove the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and keeps displaying the Learn about private search with DuckDuckGo button via the NTP

---

Verification PASSED on iPad 5th Gen running iOS 12 using 1.15 (20.03.05.14):

• verified that the STR outlined under DDG onboarding modal appears every time when creating/switching tabs in PB #2391 (comment) have been addressed/fixed
• ensured that the DDG modal is being displayed when DDG isn't the default search engine when launching PB for the first time
• ensured the following when DDG has already been set as the default search engine
  • ensured that the DDG modal doesn't appear when opening PB for the first time
  • ensured that the DDG modal doesn't appear when opening new PB tabs
  • ensured that the DDG modal doesn't appear when switching between PB tabs
  • ensured that the DDG modal doesn't appear when closing/re-opening PB mode
• ensured that switching from DDG --> Google while in PB only displays the DDG modal once
  • ensured that selecting Yes switches the search engine from Google --> DDG and doesn't display the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and displays the Learn about private search with DuckDuckGo button via the NTP
• ensured that tapping on the Learn about private search with DuckDuckGo button via NTP displays the modal
  • ensured that selecting Yes switches the search engine from Google --> DDG (PB only) and remove the Learn about private search with DuckDuckGo button via the NTP
  • ensured that selecting No dismisses the modal and keeps displaying the Learn about private search with DuckDuckGo button via the NTP