Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Make sure app background is always black. #2370

Closed
jamesmudgett opened this issue Feb 25, 2020 · 1 comment · Fixed by #2371
Closed

Make sure app background is always black. #2370

jamesmudgett opened this issue Feb 25, 2020 · 1 comment · Fixed by #2371

Comments

@jamesmudgett
Copy link
Contributor

jamesmudgett commented Feb 25, 2020

Description:

App background takes on theme home color. When presenting view controllers modally this causes issues in iOS 13 since views take on a stacked appearance.

Displaying app background as black (always) will create a more consistent stack appearance.

Steps to Reproduce

  1. Tap "Show More" on new tab page
  2. If you are currently in Light theme the background will appear light (and status bar will also be light)

Expected result:
All apple apps have a black background, which is apparent a view controller is displayed modally.

Screenshots

** Current Behavior **
This is fine:
Current Dark Theme

Notice how the app background (behind the status bar), is light, to match the theme. This is what should change.
Current Light Theme

This is the expected / new behavior. It should only impact light theme, and how the background is dark.
Expected (new) Light Theme

@kjozwiak
Copy link
Member

kjozwiak commented Mar 9, 2020

Verification PASSED on iPhone 11 running iOS 13.3.1 using 1.15 (20.03.05.13):

Example using Dark Theme

IMG_0045

Example using Light Theme

IMG_0044

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants