Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Learn more modal doesn't close other modals as well #2243

Closed
srirambv opened this issue Jan 27, 2020 · 2 comments
Closed

Learn more modal doesn't close other modals as well #2243

srirambv opened this issue Jan 27, 2020 · 2 comments

Comments

@srirambv
Copy link
Contributor

Description:

While testing #2230, found that the modals are not auto dismissed when Learn more is selected

Steps to Reproduce

  1. Install 1.14.3(20.01.25.15)
  2. Enable rewards via SNTP page
  3. Open a new tab with sponsored image, shows modal that you are earning for the NTP image
  4. Tap Learn more, opens a second modal
  5. Close second modal doesn't close the first one

Actual result:
modal

Expected result:
All modals should be closed at once when closing one of them

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.14.3(20.01.25.15)

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @iccub

@iccub
Copy link
Contributor

iccub commented Jan 28, 2020

Fixed in #2203

@iccub iccub closed this as completed Jan 28, 2020
@btlechowski
Copy link

btlechowski commented Jan 28, 2020

Verification passed on 1.14.3(20.01.28.18) on Production on iPhone SE (iOS 12.4).

  • Verified both modals are closed at the same time

Verification passed on 1.14.3(20.01.28.18) on Production on iPad 5th Gen (iOS 12).

  • Verified both modals are closed
  • Verified for both Portrait and Landscape modes

Verification passed on 1.14.3(20.01.28.18) on Production on iPad Mini (iOS 13).

  • Verified both modals are closed
  • Verified for both Portrait and Landscape modes

Verification passed on 1.14.3 (20.01.28.18) on production using iPhone 11 (iOS 13.3):

  • Verified both modals are being closed when closing the second modal via X
  • Verified both modals are being closed when closing the second modal via via the swipe gesture
  • Verified both cases using portrait and landscape modes

Verification passed on 1.14.3 (20.01.28.18) on production using iPhone 8 (iOS 13.3):

  • Verified both modals are being closed when closing the second modal via X
  • Verified both modals are being closed when closing the second modal via via the swipe gesture
  • Verified both cases using portrait and landscape modes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants