Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Database crashes with sync #2049

Closed
iccub opened this issue Nov 28, 2019 · 1 comment
Closed

Database crashes with sync #2049

iccub opened this issue Nov 28, 2019 · 1 comment
Assignees
@iccub
Labels
bug crash Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14.1

Comments

@iccub
Copy link
Contributor

iccub commented Nov 28, 2019 •
edited
Loading

We have a lot of crash reports, triggered in Sync.getExistingObjects when accessing a shared device.
This is possibly a concurrency problem.

Zrzut ekranu 2019-11-28 o 16 32 34
@iccub iccub self-assigned this Nov 28, 2019
iccub added a commit that referenced this issue Nov 28, 2019
@iccub
Fix #2049: sharedSyncDevice race conditions.
501be40 
Shared sync device was kept as a static variable. The thing is that,
NSManagedObjects are not thread safe.
This commit changes the implementation so its thread safe object id
is being kept and used to access the object.
@iccub iccub mentioned this issue Nov 28, 2019
Merged
7 tasks
@iccub iccub added this to the 1.14.1 milestone Dec 2, 2019
@jhreis jhreis closed this as completed in 63f1af7 Dec 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Dec 4, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.2 running 1.14.1(19.12.04.02)

  • Verified upgrading to 1.14.1 retained the sync devices intact
  • Verified editing/deleting bookmark from iPhone doesn't crash
  • Verified editing/deleting bookmarks from other devices propagate changes to iPhone and doesn't cause any crash
  • Verified removing other devices from sync chain doesn't cause the browser to crash on iPhone

Verification passed on iPhone 7+ with iOS 13.2 running 1.14.1(19.12.05.00)

  • Verified upgrading to 1.14.1 retained the sync devices intact
  • Verified editing/deleting bookmark from iPhone doesn't crash
  • Verified editing/deleting bookmarks from other devices propagate changes to iPhone and doesn't cause any crash
  • Verified removing other devices from sync chain doesn't cause the browser to crash on iPhone

Verification passed on iPhone Pro with iOS 13.2 running 1.14.1(19.12.5.00)

  • Verified upgrading to 1.14.1 retained the sync devices intact
  • Verified editing/deleting bookmark from iPhone doesn't crash
  • Verified editing/deleting bookmarks from other devices propagate changes to iPhone and doesn't cause any crash
  • Verified removing other devices from sync chain doesn't cause the browser to crash on iPhone

@iccub iccub mentioned this issue Jan 6, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
bug crash Epic: Sync QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14.1
Development

No branches or pull requests
2 participants
@iccub @srirambv