URL alignment is a bit off

[jumde]

Description:

Alignment of URLs in address bar is a bit off.

Steps to Reproduce

1. Navigate to wikipedia.org

Actual result:
Only edia.org is displayed in the address bar

Expected result:
wikipedia.org should be displayed

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
v1.13 (19.11.06.18)

Device details:
iPhone SE

[anthonypkeane]

Internal Chat: https://bravesoftware.slack.com/archives/C06UXF3KJ/p1573764773296000

[iccub]

This only happens with bookmarks button enabled btw

[Brandon-T]

@jumde

This issue happens because of this PR: #869
which fixes this ticket: It’s related to: #552

It seems this is 100% intentional.

The comment in the code says:

//  This override is done in case the eTLD+1 string overflows the width of textField.
//  In that case the textRect is adjusted to show right aligned and truncate left.

Expected behaviour is that the URL shifts over to highlight the "host" so the user can see whether or not it's a real domain or fake scam website.

[jhreis]

Despite this being true @Brandon-T it seems to be shifting too far to the left, the .org should at least be right-aligned here, no?

[Brandon-T]

@jhreis I fixed that part :)

It automatically fixed itself when I fixed the lock icon not showing in the url bar. It happened because of a bad layout :)

[jumde]

@jhreis I fixed that part :)

It automatically fixed itself when I fixed the lock icon not showing in the url bar. It happened because of a bad layout :)

Looks like the correct fix. Can you confirm if the test cases in #552 are not regressed? The idea is to highlight eTLD+1 when we need to truncate the URL.

[jumde]

Test Plan

1. Enable bookmarks shortcut on address bar.
2. Navigate to long URLs like:

• http://paypal-test-domain.paypal.com
• http://paypal.com/long-path-url

and verify that the eTLD+1 is highlighted.

[srirambv]

Verification passed on iPhone XR with iOS 13.5 running 1.16(20.05.05.12)

• Verified test plan from URL alignment is a bit off #1964 (comment)
• Navigating to http://paypal.com/long-path-url redirected to Paypal homepage
• Verified eTLD+1 is highlighted when bookmark button is enabled on mobile

---

Verification passed on iPhone XR with iOS 13.3.1 running 1.16(20.05.05.12)

• Verified test plan from URL alignment is a bit off #1964 (comment)
• Navigating to http://paypal.com/long-path-url redirected to Paypal homepage
• Verified eTLD+1 is highlighted when bookmark button is enabled on mobile

---

Verification passed on iPhone 6 with iOS 12.4.5 running 1.16(20.05.05.12)

• Verified test plan from URL alignment is a bit off #1964 (comment)
• Navigating to http://paypal.com/long-path-url redirected to Paypal homepage
• Verified eTLD+1 is highlighted when bookmark button is enabled on mobile

---

Marking as iPhone only as iPad URL bar is not small and entire URL is visible with or without the bookmark button