Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Decimal points are missing for JP #1767

Closed
srirambv opened this issue Oct 22, 2019 · 1 comment
Closed

Decimal points are missing for JP #1767

srirambv opened this issue Oct 22, 2019 · 1 comment
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 22, 2019 •
edited
Loading

Description:

Decimal points are missing for JP

Steps to Reproduce

  1. Change region to JP
  2. Enable Rewards
  3. USD values don't contain decimal value so 1BAT equals to 0USD

Places to add decimal values is

  • Panel summary
  • Tips panel
  • Tips message (after tipping is done)
  • Tips summary
  • Wallet summary
  • AC monthly payment

Actual result:
image

Expected result:
2 decimal points similar to all regions

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13(19.10.22.19)

Device details:
All

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.13 milestone Oct 22, 2019
@kylehickinson kylehickinson self-assigned this Oct 22, 2019
kylehickinson added a commit that referenced this issue Oct 22, 2019
@kylehickinson
Fix #1767: Return missing decimal points while in JP region
dfde221
@kylehickinson kylehickinson mentioned this issue Oct 22, 2019
Merged
7 tasks
@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.10.30.21)

  • Verified USD has 2 decimal points similar to other regions
  • Verified non-Japanese region also has 2 decimal points for USD
    xr1
    xr2
    xr3
    xr4
    xr5
    xr6
    xr7
    xr8
    xr9
    xr10
    xr11
    xr12
    xr13
    xr14
    xr15
    xr71

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.10.30.21)

  • Verified USD has 2 decimal points similar to other regions
  • Verified non-Japanese region also has 2 decimal points for USD
    iphone3
    iphone4
    iphone5
    iphone6
    iphone7
    iphone8
    iphone9
    iphone10
    iphone11
    iphone12
    iphone13
    iphone14
    iphone15

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.30.21)

  • Verified USD has 2 decimal points similar to other regions
  • Verified non-Japanese region also has 2 decimal points for USD
    ipad1
    ipad2
    ipad3
    ipad4
    ipad5
    ipad6
    ipad7
    ipad8
    ipad9
    ipad10
    ipad11

Verification passed on iPhone 6 with iOS 13.2 running 1.13(19.10.30.21)

  • Verified USD has 2 decimal points similar to other regions
  • Verified non-Japanese region also has 2 decimal points for USD
    iphone1
    iphone2
    iphone3
    iphone4
    iphone5
    iphone6
    iphone7
    iphone8
    iphone9
    iphone10
    iphone11
    iphone12
    iphone13
    iphone14
    iphone15

Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.30.21)

  • Verified USD has 2 decimal points similar to other regions
  • Verified non-Japanese region also has 2 decimal points for USD
    ac budget
    ac list
    ads
    empty tips
    Image from iOS (2)
    one time tip
    panel
    recurring tip
    tips panel
    tips processed
    tips summary
    Wallet summary after contrib
    wallet summary befrore contrib

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
2 participants
@kylehickinson @srirambv