Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rename Brave Verified Publisher to Brave Verified Creator #1711

Closed
srirambv opened this issue Oct 17, 2019 · 1 comment
Closed

Rename Brave Verified Publisher to Brave Verified Creator #1711

srirambv opened this issue Oct 17, 2019 · 1 comment
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@srirambv
Copy link
Contributor

Description:

Rename Brave Verified Publisher to Brave Verified Creator

Steps to Reproduce

  1. Enable rewards
  2. Visit any verified publisher page
  3. Open rewards panel, text shows Brave Verified Publisher, should be Brave Verified Creator

Actual result:
image

Expected result:
Similar to desktop
image

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.13(19.10.16.18)

Device details:
iPhone Xr and iPad

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@srirambv srirambv added this to the 1.13 milestone Oct 17, 2019
@kylehickinson kylehickinson self-assigned this Oct 17, 2019
kylehickinson added a commit that referenced this issue Oct 17, 2019
@kylehickinson
Fix #1706, Fix #1711: Copy fixes
0b8bba4 
`Brave Verified Publisher` -> `Brave Verified Creator`
`Minimum Length` -> `Minimum Page Time`
@kylehickinson kylehickinson mentioned this issue Oct 17, 2019
Merged
7 tasks
@srirambv
Copy link
Contributor Author

  • Verification passed on iPhone Xr with iOS 13.2 running 1.13(19.10.18.15)
    image

  • Verification passed on iPhone 7+ with iOS 13.1 running 1.13(19.10.18.15)
    image

  • Verification passed on iPad Pro with iOS 13.2 running 1.13(19.10.18.15)
    image

  • Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.10.18.15)
    image

  • Verification passed on iPad Pro with iOS 12.4 running 1.13(19.10.18.15)
    image

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kylehickinson @iccub @srirambv