Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Setup Japanese translations for Rewards UI #1698

Closed
iccub opened this issue Oct 16, 2019 · 1 comment
Closed

Setup Japanese translations for Rewards UI #1698

iccub opened this issue Oct 16, 2019 · 1 comment
Assignees
@iccub
Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.13

Comments

@iccub
Copy link
Contributor

iccub commented Oct 16, 2019

  1. Translations from Brave Rewards must be moved to Brave iOS project in transifex
  2. Push new strings, translate and pull latest translations
@iccub iccub self-assigned this Oct 16, 2019
iccub added a commit that referenced this issue Oct 16, 2019
@iccub
Fix #1698: Update translations for Rewards.
1d835bf
This was referenced Oct 16, 2019
Merged
Closed
@iccub iccub changed the title Setup translations for Rewards UI Setup Japanese translations for Rewards UI Oct 16, 2019
iccub added a commit that referenced this issue Oct 16, 2019
@iccub
Ref #1698: Add missing English translations for Rewards UI.
2e32423
iccub added a commit that referenced this issue Oct 16, 2019
@iccub
Ref #1698: Add missing English translations for Rewards UI.
ee141eb
@kylehickinson kylehickinson added this to the 1.13 milestone Oct 16, 2019
kylehickinson pushed a commit that referenced this issue Oct 16, 2019
@iccub @kylehickinson
Ref #1698: Add missing English translations for Rewards UI. (#1704)
2e81820
This was referenced Oct 31, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2019

Verification passed on iPhone XR with iOS 13.2 running 1.13(19.11.4.20)

  • Verified rewards UI/sample ad/grant message is translated to Japanese
    XR_Japanese

Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.11.4.20)

  • Verified rewards UI/sample ad/grant message is translated to Japanese
    7_Japan

Verification passed on ipad Pro with iOS 13.2 running 1.13(19.11.4.20)

  • Verified rewards UI/sample ad/grant message is translated to Japanese
    iPad_Japan

Verification passed on iPad Pro with iOS 12.4 running 1.13(19.11.4.20)

  • Verified rewards UI/sample ad/grant message is translated to Japanese

Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.11.4.20)

  • Verified rewards UI/sample ad/grant message is translated to Japanese

@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kylehickinson @iccub @srirambv