Private browsing visited sites are stored in history #168

tmancey · 2018-08-18T10:25:34Z

Actual result: Private browsing is stored in history

Expected result: Private browsing should not be stored in history

Reproduces how often: Everytime

Brave Version: 2.0 (18.08.06.15)

Device details: iPhone X (iOS 11.4.1)

Brave.sqlite data persists private browsing sites (browser.db does not persist private browsing sites)

browser.db and Model.sqlite will be removed before 2.x release after discussion with @jhreis

tmancey · 2018-08-20T13:36:35Z

History.add function should not add history when private browsing

tmancey added bug security and removed bug security labels Aug 18, 2018

tmancey mentioned this issue Aug 20, 2018

Domain history is stored in the Brave database while private browsing #169

Closed

tmancey added bug security labels Aug 22, 2018

tmancey mentioned this issue Aug 23, 2018

Sanity test file system #154

Closed

tmancey changed the title ~~Private browsing is stored in history~~ Private browsing visited sites are stored in history Aug 23, 2018

tmancey added privacy and removed security labels Aug 23, 2018

cndouglas mentioned this issue Aug 24, 2018

Fix #168: Only add url to history if the tab is not private #194

Merged

6 tasks

tmancey closed this as completed in #194 Aug 31, 2018

tmancey pushed a commit that referenced this issue Aug 31, 2018

Fix #168: Only add url to history if the tab is not private

f8b1568

tmancey pushed a commit that referenced this issue Aug 31, 2018

Resolved compiler error after merging #168

3d609ea

tmancey pushed a commit that referenced this issue Sep 11, 2018

Fix #168: Only add url to history if the tab is not private

978490e

srirambv mentioned this issue Nov 7, 2019

Implement Rewards/Ads #1920

Closed

Provide feedback