Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add Screen/UI for showing pending Contributions #1670

Closed
danishjafri88 opened this issue Jul 31, 2019 · 2 comments
Closed

Add Screen/UI for showing pending Contributions #1670

danishjafri88 opened this issue Jul 31, 2019 · 2 comments
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.15

Comments

@danishjafri88
Copy link
Contributor

danishjafri88 commented Jul 31, 2019 •
edited by kylehickinson
Loading

Currently on Desktop, users can see the list of pending contributions along with an option to remove them. This screen is missing in iOS in the current development iteration.
@anthonypkeane anthonypkeane transferred this issue from brave/brave-rewards-ios Oct 15, 2019
@anthonypkeane anthonypkeane added Epic: Rewards blocked: needs design Needs design before work can commence labels Oct 15, 2019
@anthonypkeane anthonypkeane added this to the 1.14 milestone Oct 31, 2019
@kylehickinson kylehickinson modified the milestones: 1.14, 1.15 Nov 6, 2019
@kylehickinson kylehickinson removed this from the 1.15 milestone Nov 28, 2019
@kylehickinson kylehickinson removed the blocked: needs design Needs design before work can commence label Jan 27, 2020
@kylehickinson
Copy link
Collaborator

Design:

  • Pending contributions link will be shown in the panel wallet summary under the unverified publisher BAT amount disclaimer when there are pending contributions
  • List will show site + amount like one-time tips, tapping said item will show details including the type/pending until and ability to remove the pending contribution

kylehickinson added a commit that referenced this issue Jan 28, 2020
@kylehickinson
Fix #1670: Add access to Pending Contributions
fbe0272
kylehickinson added a commit that referenced this issue Jan 28, 2020
@kylehickinson
Fix #1670: Add access to Pending Contributions
4854e71
@kylehickinson kylehickinson mentioned this issue Jan 28, 2020
Merged
7 tasks
kylehickinson added a commit that referenced this issue Jan 29, 2020
@kylehickinson
Fix #1670: Add access to Pending Contributions
c9c946b
kylehickinson added a commit that referenced this issue Jan 31, 2020
@kylehickinson
Fix #1670: Add access to Pending Contributions
14c9caa
@iccub iccub added this to the 1.15 milestone Jan 31, 2020
@srirambv srirambv mentioned this issue Feb 17, 2020
Closed
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.4 running 1.15(20.02.18.17)

  • Verified pending contribution flow works fine
  • Disclaimer
    image
  • Pending List
    image
  • Site details
    image
  • Edit mode
    image

Verification passed on iPhone 6 with iOS 12.4.5 running 1.15(20.02.18.17)

  • Verified pending contribution flow works fine
  • Disclaimer
    image
  • Pending List
    image
  • Site details
    image
  • Edit mode
    image

Verification passed on iPhone 7+ with iOS 13.3.1 running 1.15(20.02.18.17)

  • Verified pending contribution flow works fine
  • Disclaimer
    image
  • Pending List
    image
  • Site details
    image
  • Edit mode
    image

Verification passed on iPad Pro with iOS 13.3.1 running 1.15(20.02.18.17)

  • Verified pending contribution flow works fine
  • Disclaimer
    image
  • Pending List
    image
  • Site details
    image
  • Edit mode
    image

Verification passed on iPad Pro with iOS 12.4.4 running 1.15(20.02.18.17)

  • Verified pending contribution flow works fine
  • Disclaimer
    image
  • Pending List
    image
  • Site details
    image
  • Edit mode
    image

@srirambv srirambv mentioned this issue Feb 19, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Apr 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.15
Development

No branches or pull requests
6 participants
@jamesmudgett @kylehickinson @danishjafri88 @iccub @anthonypkeane @srirambv