Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

BAT Points Changes #1651

Closed
kylehickinson opened this issue Oct 10, 2019 · 1 comment
Closed

BAT Points Changes #1651

kylehickinson opened this issue Oct 10, 2019 · 1 comment
Assignees
@kylehickinson
Labels
enhancement Epic: Rewards QA/No release-notes/exclude
Milestone
1.13

Comments

@kylehickinson
Copy link
Collaborator

BAT → BAT points (or Points) for JP localization

Includes a few different changes that actually require logic changes around JP region

See BAT Points (Simple version) on GDrive

Link in with Deep on how Android will implement this too.
@kylehickinson kylehickinson changed the title BAT Points Copy Changes BAT Points Changes Oct 11, 2019
@anthonypkeane anthonypkeane transferred this issue from brave/brave-rewards-ios Oct 15, 2019
@anthonypkeane anthonypkeane added this to the 1.13 milestone Oct 15, 2019
@kylehickinson kylehickinson self-assigned this Oct 16, 2019
kylehickinson added a commit that referenced this issue Oct 22, 2019
@kylehickinson
Fix #1651: Update Rewards UI based on if region is set to JP
06debc1 
- "BAT" becomes "BAT Points" in most scenarios
- An additional disclaimer message is shown in the rewards summary (when non-empty)
- Powered by Uphold message is not shown in wallet details screen
@kylehickinson kylehickinson mentioned this issue Oct 22, 2019
Merged
7 tasks
@srirambv
Copy link
Contributor

Marking as QA/No as this is superseded by #1822

@srirambv srirambv added QA/No and removed QA/Yes labels Oct 30, 2019
@srirambv srirambv mentioned this issue Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: Rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
3 participants
@kylehickinson @anthonypkeane @srirambv