Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Need a way to view download content #1467

Closed
jamesmudgett opened this issue Sep 1, 2019 · 1 comment
Closed

Need a way to view download content #1467

jamesmudgett opened this issue Sep 1, 2019 · 1 comment
Assignees
@kylehickinson
Labels
enhancement Epic: UI/UX feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.14

Comments

@jamesmudgett
Copy link
Contributor

New download feature has no way to view download. Downloaded a jpg and wasn’t able to open for viewing.

Would be great to use QL Preview controller here as it provides lots of native functionality and supports many different file types.
@jamesmudgett jamesmudgett added this to the 1.12 milestone Sep 1, 2019
@srirambv srirambv added the QA/Yes label Sep 5, 2019
@iccub iccub removed this from the 1.12 milestone Sep 5, 2019
@kylehickinson kylehickinson mentioned this issue Nov 16, 2019
Closed
kylehickinson added a commit that referenced this issue Nov 18, 2019
@kylehickinson
Fix #1467: Display a QuickLook preview when tapping a downloaded file
619d944 
Falls back to previous logic if the QuickLook service isn't able to preview the document type
@kylehickinson kylehickinson mentioned this issue Nov 18, 2019
Merged
7 tasks
kylehickinson added a commit that referenced this issue Nov 18, 2019
@kylehickinson
Fix #1467: Display a QuickLook preview when tapping a downloaded file
e907b69 
Falls back to previous logic if the QuickLook service isn't able to preview the document type
@iccub iccub added this to the 1.14 milestone Nov 18, 2019
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.19.15)

  • Verified downloaded items shows preview window when clicked on the downloaded file in download sheet
  • Verified PDF/JPEG/Gif images preview is shown
    xrpreview

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.19.15)

  • Verified downloaded items shows preview window when clicked on the downloaded file in download sheet
  • Verified PDF/JPEG/Gif images preview is shown
    7preview

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.19.15)

  • Verified downloaded items shows preview window when clicked on the downloaded file in download sheet
  • Verified PDF/JPEG/Gif images preview is shown
    pad13preview

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.19.15)

  • Verified downloaded items shows preview window when clicked on the downloaded file in download sheet
  • Verified PDF/JPEG/Gif images preview is shown
    6preview

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.19.15)

  • Verified downloaded items shows preview window when clicked on the downloaded file in download sheet
  • Verified PDF/JPEG/Gif images preview is shown
    pad12preview

@srirambv srirambv mentioned this issue Nov 25, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: UI/UX feature-request QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
5 participants
@jamesmudgett @kylehickinson @jhreis @iccub @srirambv