User agent on iPad should default to a desktop one.

[iccub]

Description:

Steps to Reproduce

1. Visit a website

Actual result:

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

Device details:

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

[Brandon-T]

Hmm.. this seems to have adverse effects (on iPad).
IE: if we change it to let firefoxUA = UIDevice.current.userInterfaceIdiom == .pad ? UserAgent.desktopUserAgent() : UserAgent.defaultUserAgent()

It will work.. however, sites like Youtube will disable fullscreen because they are checking for document.fullscreenEnabled || mozFullScreenEnabled || msFullscreenEnabled || document.webkitFullscreenEnabled ? true : false

but it always returns false on iOS WebKit (it's a bug because if you do videoElement.requestFullScreen() || videoElement.webKitRequestFullScreen()).. it works :(

Is it only for certain sites or all? Is there an option to select the user agent somewhere?

[iccub]

there's customUserAgent property in WKWebView, you can use it even now by tapping on Share button in menu and select request desktop site. I am not sure how robust this is

[kjozwiak]

Verification PASSED on iPad Air 3rd Generation iOS 13.1 running 1.12 (19.09.11.15):

• Visited the following websites and ensured that the desktop version was being loaded:
  • youtube.com, amazon.com, ebay.com, coinmarketcap.com, facebook.com

Verification PASSED on iPad Air 3rd Generation iOS 13.1 running 1.12 (19.09.11.14):

• Visited the following websites and ensured that the desktop version was being loaded:
  • youtube.com, amazon.com, ebay.com, coinmarketcap.com, facebook.com