Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

shields breaking https://coinmarketcap.com #1241

Closed
kjozwiak opened this issue Jul 12, 2019 · 8 comments
Closed

shields breaking https://coinmarketcap.com #1241

kjozwiak opened this issue Jul 12, 2019 · 8 comments

Comments

@kjozwiak
Copy link
Member

Description:

Shields is breaking https://coinmarketcap.com which is a problem as it's one of the sites that appears default under Favourites/NTP. It's not reproducible on 1.9.3 (19.05.22.15) which is the current App Store release. Assuming it regressed somewhere in 1.10.

Steps to Reproduce

  1. Install 1.10 (19.07.10.17) via TF
  2. Once installed, tap on the https://coinmarketcap.com icon on the NTP

Actual result:

IMG_9759

Expected result:

IMG_9760

Reproduces how often: [Easily reproduced, Intermittent Issue]

100% reproducible using the above STR.

Brave Version:

  • Using 1.10 (19.07.10.17)

Device details:

  • iPad Mini 4 running iOS 12.3.1 using 1.10 (19.07.10.17) - Reproduced
  • iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.10.17) - Reproduced

Website problems only:

  • did you check with Brave Shields down? Loads correctly when shields are down
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

@iccub
Copy link
Contributor

iccub commented Jul 15, 2019

This seems to be working now on latest build, please recheck it cc @LaurenWags

@iccub iccub closed this as completed Jul 15, 2019
@kjozwiak
Copy link
Member Author

@iccub I can still reproduce the above using 1.1.0 (19.07.12.14) on both iPad Mini 4 & iPhone 6s+ which are both running iOS 12.3.1. @LaurenWags can you reproduce this on your end?

@iccub is 1.1.0 (19.07.12.14) the latest build? If not, can we get the latest version uploaded into TF?

@iccub
Copy link
Contributor

iccub commented Jul 15, 2019

Yes, latest development version should hopefully fix that.

You could also try on fresh install, maybe something got stuck

@kjozwiak
Copy link
Member Author

You could also try on fresh install, maybe something got stuck

@iccub those were on clean profiles. I'll wait till TF gets updated with the latest version.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 15, 2019

@kjozwiak yes, I can reproduce on same version you listed 1.10 (19.07.12.14) on iPad 5th Gen which is running iOS 12.3.1 also. Clean profile as well.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 16, 2019

Issue reproduces with latest Beta 1.10 (19.07.16.21) using iPad 5th Gen.

@LaurenWags LaurenWags reopened this Jul 16, 2019
@kjozwiak
Copy link
Member Author

Same results as @LaurenWags with 1.10 (19.07.16.21), example:

  • iPad Mini 4 running iOS iOS 12.3.1 using 1.10 (19.07.16.21) --> Reproduced
  • iPhone 6s+ running iOS iOS 12.3.1 using 1.10 (19.07.16.21) --> Reproduced

Again, I can't reproduce this with the latest release that's out on the App Store, example:

  • iPad Mini 4 running iOS iOS 12.3.1 using 1.9.3 (19.05.22.15) --> Couldn't reproduce
  • iPhone 6s+ running iOS iOS 12.3.1 using 1.9.3 (19.05.22.15) --> Couldn't reproduce

I also double checked Android 1.1.1 CR: 75.0.3770.101 which was just pushed live and it seems to . be working without any issues as well.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2019

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.16.23)

IMG_FEACE576EBD3-1

  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)

IMG_E64ECB002AE7-1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants