Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Print button is unresponsive for Online PDF bank statements #1144

Closed
GeetaSarvadnya opened this issue Jun 12, 2019 · 2 comments · Fixed by #1237
Closed

Print button is unresponsive for Online PDF bank statements #1144

GeetaSarvadnya opened this issue Jun 12, 2019 · 2 comments · Fixed by #1237
Assignees
@Brandon-T
Labels
bug QA/Yes release-notes/include
Milestone
1.11

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 12, 2019 •
edited
Loading

Description:

Print button is unresponsive for Online PDF bank statements

Steps to Reproduce

  1. Clean profile 1.9.3
  2. Open online PDF bank statements
  3. Tap on the Action button at the bottom in the iOS device
  4. Tap on "Print" button

Note: Please note this issue is happening only for online PDF bank statements.

Actual result:
The print button becomes unresponsive and it doesn't open the print preview page.

Expected result:
Tap on "Print" button should show a print preview page and allow the user to print the PDF

Reproduces how often: [Easily reproduced, Intermittent Issue]
Always

Brave Version:
1.9.3 (19.05.22.15)

Device details:
iPhone 8 - iOS 12.3.1

Website problems only:

  • did you check with Brave Shields down? Yes - It did not resolve the issue
  • did you check in Safari/Firefox (WkWebView-based browsers)? Yes - works fine in safari

Additional Information

cc: @brave/legacy_qa @jhreis
The issue is reported by the community user
https://community.brave.com/t/print-button-unresponsive-on-ipad/64083
@GeetaSarvadnya GeetaSarvadnya added this to the 1.0.94 milestone Jun 12, 2019
@srirambv srirambv removed this from the 1.0.94 milestone Jun 20, 2019
@EvidenceAlpha
Copy link

Any update on this issue ? Thanks

@Brandon-T Brandon-T self-assigned this Jul 9, 2019
@Brandon-T Brandon-T mentioned this issue Jul 9, 2019
Closed
14 tasks
Brandon-T added a commit that referenced this issue Jul 11, 2019
@Brandon-T
Fixes #1144
cf96e9a 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
@Brandon-T Brandon-T mentioned this issue Jul 11, 2019
Merged
14 tasks
Brandon-T added a commit that referenced this issue Jul 12, 2019
@Brandon-T
Fixes #1144
f6204ce 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
Brandon-T added a commit that referenced this issue Jul 15, 2019
@Brandon-T
Fixes #1144
e721c44 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
Brandon-T added a commit that referenced this issue Jul 17, 2019
@Brandon-T
Fixes #1144
5bfb3cc 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
Brandon-T added a commit that referenced this issue Jul 19, 2019
@Brandon-T
Fixes #1144
af6fefb 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
Brandon-T added a commit that referenced this issue Jul 23, 2019
@Brandon-T
Fixes #1144
ee6153b 
Fixed a background thread issue where "displayTitle" is being called on WKWebView on a non-main thread causing the PrintPreview to have undefined-behaviour.
Fixed opening Authenticated documents in Private-Browsing mode when it opens in a new tab.
Fixed opening Authenticated documents and attempting to share, or print them.
Fixes tabs not having the same data store as other tabs (IE: Log-In to any website on one tab should log you in on another tab).
Fixed destroying of data-store to only happen when ALL tabs are destroyed.
Changed Temporary Storage to pull out the document from the WebPage instead of making server calls outside the webview's session (IE: No need for cookie injecting, etc).. Instead, we get the webview to give us the document via Javascript injection which passes the document to iOS for display/saving, etc..
Brandon-T added a commit that referenced this issue Jul 23, 2019
@Brandon-T
Fix #1144: Sharing of session and Authenticated Documents between tabs (
1c95231 
#1237)
@jhreis jhreis modified the milestones: 1.10, 1.11 Jul 23, 2019
@srirambv
Copy link
Contributor

srirambv commented Jul 25, 2019 •
edited
Loading

  • Verification passed on iPhone 7+ (iOS 12.3.1) running 1.10(19.7.24.20)
    • Verified app doesn't hang when print preview is clicked
    • Verified able to generate print preview for online bank statements
  • Verification PASSED on iPad Mini 4 iOS 12.3.1 running 1.10 (19.7.24.20)
    • ensured that print preview doesn't cause any hangs on several websites and PDF's
    • ensured that print preview doesn't cause any hangs when viewing banking statements
    • ensured printing works
  • Verification passed on iPad Pro (iOS 12.3.1) running 1.10(19.7.24.20)
    • Verified app doesn't hang when print preview is clicked
    • Verified able to generate print preview for online bank statements

@srirambv srirambv mentioned this issue Jul 29, 2019
Closed
@jhreis jhreis modified the milestones: 1.10, 1.10.1 Jul 31, 2019
@srirambv srirambv mentioned this issue Aug 1, 2019
Closed
@Brandon-T Brandon-T mentioned this issue Jan 8, 2020
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug QA/Yes release-notes/include
Projects
None yet
Milestone
1.11
6 participants
@Brandon-T @kjozwiak @jhreis @srirambv @GeetaSarvadnya @EvidenceAlpha