Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

3D Touch cursor in address bar #1081

Closed
oloverm opened this issue May 6, 2019 · 6 comments
Closed

3D Touch cursor in address bar #1081

oloverm opened this issue May 6, 2019 · 6 comments

Comments

@oloverm
Copy link

oloverm commented May 6, 2019

Description:

3D-touching the keyboard on iPhones should let you move the cursor around. It works in text fields, but not the address bar.

Steps to Reproduce

  1. Select address bar
  2. 3D Touch the keyboard

Actual result:
Haptic feedback but no cursor movement

Expected result:
Haptic feedback and you can move the cursor back and forth

Reproduces how often: [Easily reproduced, Intermittent Issue]
Always

Brave Version:
Version 1.9.1 (19.04.02.12)

Device details:
iPhone XS iOS 12.2

@srirambv
Copy link
Contributor

srirambv commented May 7, 2019

This works in URL bar only if the text is not highlighted.
ezgif-5-f2a130053caf

Not sure if its supposed to work on text highlight. This is recorded on iPhone 7+

@oloverm
Copy link
Author

oloverm commented May 7, 2019

It does work even when the text is highlighted in Safari.

@srirambv
Copy link
Contributor

srirambv commented May 7, 2019

So Safari is basically removing the text highlight and then scrolls using 3D touch. We should probably do the same.

cc: @iccub @danishjafri88

@oloverm
Copy link
Author

oloverm commented May 7, 2019

It’s the same as for text across iOS by the way, not specific to URL bars. If you highlight something in the Notes app and then try to move around with 3D Touch it’ll un-highlight it and give you a cursor.

@kylehickinson
Copy link
Collaborator

This should be fixed now that #1990 is merged

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.20.19)

  • Verified editing URL highlights the URL and 3D touch allows cursor movement when URL is highlighted

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.20.19)

  • Verified editing URL highlights the URL and 3D touch allows cursor movement when URL is highlighted

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.20.19)

  • Verified editing URL highlights the URL and 3D touch allows cursor movement when URL is highlighted

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.20.19)

  • Verified editing URL highlights the URL and 3D touch allows cursor movement when URL is highlighted

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.20.19)

  • Verified editing URL highlights the URL and 3D touch allows cursor movement when URL is highlighted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants