Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Peek/pop 3D touch #1080

Closed
oloverm opened this issue May 6, 2019 · 6 comments · Fixed by #1108
Closed

Peek/pop 3D touch #1080

oloverm opened this issue May 6, 2019 · 6 comments · Fixed by #1108
Labels
enhancement good first issue iPhone-specific QA/Yes release-notes/include won't have Requirement which the project team has agreed it will not deliver

Comments

@oloverm
Copy link

oloverm commented May 6, 2019

Description:

Not being able to use peek and pop on links or images is the only thing that makes me want to switch back to Safari. The long press is just too slow and it doesn’t show you the peek preview.

@kylehickinson
Copy link
Collaborator

Related APIs to add this support: https://webkit.org/blog/7016/ios-10-link-preview-api-in-wkwebview/

@mollyIV
Copy link
Contributor

mollyIV commented May 27, 2019

Hey guys 👋

If you do not mind and nobody is working on this issue, I would like to give it a shoot as a first good issue 🙂💪

Peek and Pop will be a great feature to have in Brave browser, I am very excited about it 🚀

@iccub
Copy link
Contributor

iccub commented May 28, 2019

I wonder if it's even worth implementing given that 3d touch could be removed in the future

https://forums.macrumors.com/threads/apple-expected-to-remove-3d-touch-from-all-2019-iphones-in-favor-of-haptic-touch.2182908/

@mollyIV our project manager @jhreis is on PTO, I will ping him after he's back to answer you :)

@mollyIV
Copy link
Contributor

mollyIV commented May 29, 2019

👋 I opened a draft pull request to make a discussion easier 🙂

#1108

@jhreis
Copy link
Contributor

jhreis commented Sep 6, 2019

We had to revert this due to iOS 13 gesture conflicts (commit b3f412b). Re-opening for now.

@jhreis jhreis reopened this Sep 6, 2019
@iccub iccub added the won't have Requirement which the project team has agreed it will not deliver label Dec 10, 2019
@iccub
Copy link
Contributor

iccub commented Dec 10, 2019

This isn't easy to fix in iOS 12, iOS 13 support this out of the box.
Labelling as won't have for versions earlier than iOS 13

@iccub iccub closed this as completed Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement good first issue iPhone-specific QA/Yes release-notes/include won't have Requirement which the project team has agreed it will not deliver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants