Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Bring back Find in page via url bar #1019

Closed
iccub opened this issue Apr 1, 2019 · 3 comments
Closed

Bring back Find in page via url bar #1019

iccub opened this issue Apr 1, 2019 · 3 comments
Assignees
@iccub
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.10

Comments

@iccub
Copy link
Contributor

iccub commented Apr 1, 2019

We had this feature in Brave 1.6 and removed it by accident while moving onto 1.7 codebase.
@anthonypkeane
Copy link

#868 should sort it
LMK if not

@iccub iccub self-assigned this Jul 8, 2019
iccub added a commit to iccub/brave-ios that referenced this issue Jul 9, 2019
@iccub
Fix brave#1019: Add 'Find in page' to search panel.
7bacd60
iccub added a commit to iccub/brave-ios that referenced this issue Jul 9, 2019
@iccub
Fix brave#1019: Add 'Find in page' to search panel.
c17857e
@iccub iccub closed this as completed in 1167229 Jul 10, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2019 •
edited by kjozwiak
Loading

  • Verified passed on iPad 5th Gen (iOS 12.3.1) running 1.10 (19.07.12.14)
    • Navigated to a page, tapped on URL bar, typed text into URL bar and saw 'On this page' in drop down and the option to 'Find' my text. Finding my text worked as expected. Selecting 'Cancel' returned me to my page as expected.

IMG_554399E7AFFA-1

  • Verification PASSED on iPhone 6s+ running iOS 12.3.1 using 1.10 (19.07.16.23)
    • ensured that typing into the URL while your on a page displays On this page
    • ensured that taping on your text under On this page finds the correct text and the correct results
    • ensured that Find feature works as expected when using it via On this page

IMG_9786

@kjozwiak kjozwiak added this to the 1.10 milestone Jul 18, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jul 19, 2019 •
edited
Loading

@anthonypkeane @EyanGoldman as this is a design/UX issue, can you guys go through this on an iPhone X? If you've already been dog fooding and feel comfortable with the new design/functionality, can either of you please add the QA Pass - iPhone X label? Thanks!

@srirambv srirambv mentioned this issue Jul 29, 2019
Closed
@srirambv srirambv mentioned this issue Sep 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iccub iccub

Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
6 participants
@kjozwiak @iccub @anthonypkeane @EyanGoldman @srirambv @LaurenWags