Ref #4329: Favorite Widgets crash.

brave · Nov 12, 2021 · fc50510 · fc50510
1 parent 6bdda38
commit fc50510
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Client/Frontend/Browser/BrowserViewController/BrowserViewController+Widgets.swift b/Client/Frontend/Browser/BrowserViewController/BrowserViewController+Widgets.swift
@@ -21,7 +21,7 @@ extension BrowserViewController: NSFetchedResultsControllerDelegate {
             for (index, fav) in favs.prefix(16).enumerated() {
                 if let url = fav.url?.asURL {
                     group.enter()
-                    let fetcher = FaviconFetcher(siteURL: url, kind: .largeIcon)
+                    let fetcher = FaviconFetcher(siteURL: url, kind: .largeIcon, persistentCheckOverride: true)
                     widgetFaviconFetchers.append(fetcher)
                     fetcher.load { _, attributes in
                         favData[index] = .init(url: url, favicon: attributes)

diff --git a/Client/Frontend/Browser/Favicons/FaviconFetcher.swift b/Client/Frontend/Browser/Favicons/FaviconFetcher.swift
@@ -55,12 +55,12 @@ class FaviconFetcher {
 
     static let defaultFaviconImage = #imageLiteral(resourceName: "defaultFavicon")
 
-    init(siteURL: URL, kind: Kind, domain: Domain? = nil) {
+    init(siteURL: URL, kind: Kind, domain: Domain? = nil, persistentCheckOverride: Bool? = nil) {
         self.url = siteURL
         self.kind = kind
         self.domain = domain ?? Domain.getOrCreate(
             forUrl: siteURL,
-            persistent: !PrivateBrowsingManager.shared.isPrivateBrowsing
+            persistent: persistentCheckOverride ?? !PrivateBrowsingManager.shared.isPrivateBrowsing
         )
     }