Fix #7733: Allow Custom Search Engines to be default in Private Mode (#…

…7734) Allowing custom Search Engines be default search engine for private mode
brave · Jul 14, 2023 · e8e37a8 · e8e37a8
1 parent feb95c9
commit e8e37a8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/Sources/Brave/Frontend/Browser/Search/SearchSuggestionDataSource.swift b/Sources/Brave/Frontend/Browser/Search/SearchSuggestionDataSource.swift
@@ -109,7 +109,7 @@ class SearchSuggestionDataSource {
 
   func querySuggestClient() {
     // Do not query suggestions if user is not opt_ed in
-    if !Preferences.Search.shouldShowSuggestionsOptIn.value {
+    if !Preferences.Search.showSuggestions.value {
       Logger.module.info("Suggestions are not enabled")
       return
     }

diff --git a/Sources/Brave/Frontend/Settings/SearchSettingsTableViewController.swift b/Sources/Brave/Frontend/Settings/SearchSettingsTableViewController.swift
@@ -67,12 +67,6 @@ class SearchSettingsTableViewController: UITableViewController {
       .sorted { $0.shortName < $1.shortName }
       .sorted { engine, _ in engine.shortName == OpenSearchEngine.EngineNames.brave }
 
-    if isPrivate {
-      orderedEngines =
-        orderedEngines
-        .filter { !$0.isCustomEngine || $0.engineID == OpenSearchEngine.migratedYahooEngineID }
-    }
-
     if let priorityEngine = InitialSearchEngines().priorityEngine?.rawValue {
       orderedEngines =
         orderedEngines