Fix #8705: Add display for version info (#8706)

- Add display for version info
brave · Feb 7, 2024 · d480090 · d480090
1 parent 18bb268
commit d480090
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/Sources/Brave/Frontend/Settings/SettingsViewController.swift b/Sources/Brave/Frontend/Settings/SettingsViewController.swift
@@ -741,9 +741,22 @@ class SettingsViewController: TableViewController {
               UIPasteboard.general.setSecureString(AppStorageDebugComposer.compose(),
                                                    expirationDate: Date().addingTimeInterval(2.minutes))
             }
+
+            let viewMoreDetails = UIAlertAction(title: Strings.viewAllVersionInfo, style: .default) { [unowned self, weak actionSheet] _ in
+              let versionController = p3aUtilities.histogramsController().then {
+                //TODO: Remove in 1.63.x
+                $0.loadViewIfNeeded()
+                $0.perform(Selector("loadURL:"), with: "chrome://version?show-variations-cmd")
+              }
+
+              actionSheet?.dismiss(animated: true, completion: {
+                self.present(versionController, animated: true)
+              })
+            }
 
             actionSheet.addAction(copyDebugInfoAction)
             actionSheet.addAction(copyAppInfoAction)
+            actionSheet.addAction(viewMoreDetails)
             actionSheet.addAction(UIAlertAction(title: Strings.cancelButtonTitle, style: .cancel, handler: nil))
             self.navigationController?.present(actionSheet, animated: true, completion: nil)
           }, cellClass: MultilineValue1Cell.self),

diff --git a/Sources/BraveStrings/BraveStrings.swift b/Sources/BraveStrings/BraveStrings.swift
@@ -1167,6 +1167,7 @@ extension Strings {
   NSLocalizedString("copyAppSizeInfoToClipboard", tableName: "BraveShared",
                     bundle: .module, value: "Copy app size info to clipboard.",
                     comment: "Copy app info to clipboard action sheet action.")
+  public static let viewAllVersionInfo = NSLocalizedString("copyAppSizeInfoToClipboard", tableName: "BraveShared", bundle: .module, value: "View all version info.", comment: "View all version info action sheet action.")
   public static let blockThirdPartyCookies = NSLocalizedString("Block3rdPartyCookies", tableName: "BraveShared", bundle: .module, value: "Block 3rd party cookies", comment: "cookie settings option")
   public static let blockAllCookies = NSLocalizedString("BlockAllCookies", tableName: "BraveShared", bundle: .module, value: "Block all Cookies", comment: "Title for setting to block all website cookies.")
   public static let blockAllCookiesAction = NSLocalizedString("BlockAllCookiesAction", tableName: "BraveShared", bundle: .module, value: "Block All", comment: "block all cookies settings action title")