Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
No Bug: Remove redundant compile time flags (#3085)
Browse files Browse the repository at this point in the history
  • Loading branch information
kylehickinson authored Nov 26, 2020
1 parent 4f6bec5 commit cf23543
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 26 deletions.
2 changes: 1 addition & 1 deletion Client/Configuration/Base.xcconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "Local/BuildId.xcconfig"
#include "Local/Version.xcconfig"

OTHER_SWIFT_FLAGS_BASE=-DMOZ_TARGET_$(TARGET_NAME:upper) -DNO_USER_WALLETS -DNO_SKUS
OTHER_SWIFT_FLAGS_BASE=-DMOZ_TARGET_$(TARGET_NAME:upper)

FRAMEWORK_BASE_BUNDLE_ID = com.brave
BASE_BUNDLE_ID = $(FRAMEWORK_BASE_BUNDLE_ID).ios
Expand Down
4 changes: 0 additions & 4 deletions Client/Frontend/Browser/BrowserViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2491,10 +2491,6 @@ extension BrowserViewController: TabDelegate {

tab.addContentScript(RewardsReporting(rewards: rewards, tab: tab), name: RewardsReporting.name())
tab.addContentScript(AdsMediaReporting(rewards: rewards, tab: tab), name: AdsMediaReporting.name())

#if !NO_SKUS
tab.addContentScript(PaymentRequestExtension(rewards: rewards, tab: tab, paymentRequested: self.paymentRequested), name: PaymentRequestExtension.name())
#endif
}

func tab(_ tab: Tab, willDeleteWebView webView: WKWebView) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,21 +142,6 @@ extension BrowserViewController: WKNavigationDelegate {
decisionHandler(.cancel)
return
}

#if !NO_USER_WALLETS
if isUpholdOAuthAuthorization(url) {
decisionHandler(.cancel)
guard let tab = tabManager[webView], let queryItems = URLComponents(url: url, resolvingAgainstBaseURL: false)?.queryItems else {
return
}
var items: [String: String] = [:]
for query in queryItems {
items[query.name] = query.value
}
authorizeUpholdWallet(from: tab, queryItems: items)
return
}
#endif

// First special case are some schemes that are about Calling. We prompt the user to confirm this action. This
// gives us the exact same behaviour as Safari.
Expand Down
6 changes: 0 additions & 6 deletions Client/Frontend/Browser/UserScriptManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,6 @@ class UserScriptManager {
if let domainUserScript = domainUserScript, let script = domainUserScript.script {
$0.addUserScript(script)
}

#if !NO_SKUS
if isPaymentRequestEnabled, let script = PaymentRequestUserScript {
$0.addUserScript(script)
}
#endif
}
}
}

0 comments on commit cf23543

Please sign in to comment.