Fix #8451: Defer toolbar state updates on viewWillAppear by 1 cycle (…

…#8452)

For some reason without this there's a chance iOS lays out the toolbars without any safe area insets

Sources/Brave/Frontend/Browser/BrowserViewController.swift

@@ -1117,10 +1117,14 @@ public class BrowserViewController: UIViewController {
   override public func viewWillAppear(_ animated: Bool) {
     super.viewWillAppear(animated)
     if #available(iOS 17, *) {
-      // On iOS 17 rotating the device with a full screen modal presented (e.g. Playlist, Tab Tray)
-      // to landscape then back to portrait does not trigger `traitCollectionDidChange`/`willTransition`/etc
-      // calls and so the toolbar remains in the wrong state.
-      updateToolbarStateForTraitCollection(traitCollection)
+      // Have to defer this to the next cycle to avoid an iOS bug which lays out the toolbars without any
+      // bottom safe area, resulting in a layout bug.
+      DispatchQueue.main.async {
+        // On iOS 17 rotating the device with a full screen modal presented (e.g. Playlist, Tab Tray)
+        // to landscape then back to portrait does not trigger `traitCollectionDidChange`/`willTransition`/etc
+        // calls and so the toolbar remains in the wrong state.
+        self.updateToolbarStateForTraitCollection(self.traitCollection)
+      }
     }
     updateToolbarUsingTabManager(tabManager)