Fix #8255: Reordering Favourites shows duplicated items (#8314)

brave · Oct 30, 2023 · a6dd424 · a6dd424
1 parent 2ee257b
commit a6dd424
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/Sources/Brave/Frontend/Browser/New Tab Page/NewTabPageViewController.swift b/Sources/Brave/Frontend/Browser/New Tab Page/NewTabPageViewController.swift
@@ -1232,13 +1232,21 @@ extension NewTabPageViewController: UICollectionViewDragDelegate, UICollectionVi
 
     if coordinator.proposal.operation == .move {
       guard let item = coordinator.items.first else { return }
+      _ = coordinator.drop(item.dragItem, toItemAt: destinationIndexPath)
 
+      guard let favouritesSection = sections.firstIndex(where: { $0 is FavoritesSectionProvider }) else {
+        return
+      }
+
       Favorite.reorder(
         sourceIndexPath: sourceIndexPath,
         destinationIndexPath: destinationIndexPath,
         isInteractiveDragReorder: true
       )
-      _ = coordinator.drop(item.dragItem, toItemAt: destinationIndexPath)
+
+      UIView.performWithoutAnimation {
+        self.collectionView.reloadSections(IndexSet(integer: favouritesSection))
+      }
 
     }
   }