address review comments.

brave · Apr 21, 2023 · a2ebaff · a2ebaff
1 parent eb5ed03
commit a2ebaff
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Sources/BraveWallet/Crypto/Asset Details/AssetDetailView.swift b/Sources/BraveWallet/Crypto/Asset Details/AssetDetailView.swift
@@ -151,7 +151,7 @@ struct AssetDetailView: View {
               let computed = assetDetailStore.currencyFormatter.string(from: NSNumber(value: BraveWallet.CoinMarket.abbreviateToBillion(input: coinMarket.totalVolume))) ?? ""
               Text("\(computed)B")
                 .font(.title3.weight(.semibold))
-              Text(Strings.Wallet.coinMarket24HVolumn)
+              Text(Strings.Wallet.coinMarket24HVolume)
                 .font(.footnote)
             }
             Spacer()

diff --git a/Sources/BraveWallet/Crypto/Market/MarketView.swift b/Sources/BraveWallet/Crypto/Market/MarketView.swift
@@ -91,7 +91,7 @@ struct MarketView: View {
     ForEach(0...10, id: \.self) { _ in
       HStack {
         if sizeCategory.isAccessibilityCategory {
-          VStack(spacing: 8) {
+          VStack(alignment: .leading, spacing: 8) {
             loadingTokenPlaceholder
           }
         } else {
@@ -116,7 +116,7 @@ struct MarketView: View {
     List {
       Section {
         Group {
-          if marketStore.isLoading {
+          if marketStore.isLoading && marketStore.coins.isEmpty {
             loadingView
           } else if marketStore.coins.isEmpty {
             emptyState

diff --git a/Sources/BraveWallet/WalletStrings.swift b/Sources/BraveWallet/WalletStrings.swift
@@ -3960,12 +3960,12 @@ extension Strings {
       value: "Rank",
       comment: "The title of the rank of this coin from market."
     )
-    public static let coinMarket24HVolumn = NSLocalizedString(
-      "wallet.coinMarket24HVolumn",
+    public static let coinMarket24HVolume = NSLocalizedString(
+      "wallet.coinMarket24HVolume",
       tableName: "BraveWallet",
       bundle: .module,
-      value: "24h Volumn",
-      comment: "The title of the 24h volumn of this coin from market."
+      value: "24h Volume",
+      comment: "The title of the 24h volume of this coin from market."
     )
     public static let coinMarketMarketCap = NSLocalizedString(
       "wallet.coinMarketMarketCap",