Fix #1786: Don't use probi value for USD conversion on one-time tips

brave · Oct 24, 2019 · 79eda0d · 79eda0d
1 parent 9e1b0f2
commit 79eda0d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/BraveRewardsUI/Settings/Tips/Details/TipsDetailViewController.swift b/BraveRewardsUI/Settings/Tips/Details/TipsDetailViewController.swift
@@ -195,16 +195,19 @@ extension TipsDetailViewController: UITableViewDataSource, UITableViewDelegate {
       let contribution = tip.weight
       switch tip.rewardsCategory {
       case .oneTimeTip:
+        let value = BATValue(probi: "\(contribution)")
         cell.typeNameLabel.text = Strings.OneTimeText + Date.stringFrom(reconcileStamp: tip.reconcileStamp)
-        cell.tokenView.batContainer.amountLabel.text = BATValue(probi: "\(contribution)")?.displayString
+        cell.tokenView.batContainer.amountLabel.text = value?.displayString
+        cell.tokenView.usdContainer.amountLabel.text = state.ledger.dollarStringForBATAmount(value?.doubleValue ?? 0, includeCurrencyCode: false)
       case .recurringTip:
         cell.tokenView.batContainer.amountLabel.text = BATValue(contribution).displayString
+        cell.tokenView.usdContainer.amountLabel.text = state.ledger.dollarStringForBATAmount(contribution, includeCurrencyCode: false)
         cell.typeNameLabel.text = Strings.RecurringText
       default:
         cell.tokenView.batContainer.amountLabel.text = ""
+        cell.tokenView.usdContainer.amountLabel.text = ""
         cell.typeNameLabel.text = ""
       }
-      cell.tokenView.usdContainer.amountLabel.text = state.ledger.dollarStringForBATAmount(contribution, includeCurrencyCode: false)
       return cell
     }
   }