Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Ref #8078: Fix collapsed URL bar background color
Browse files Browse the repository at this point in the history
The tabs bar now has a background and in general colors around these have changed so we can now just set the alpha of the tabs bar entirely instead of the subviews alone
  • Loading branch information
kylehickinson committed Oct 6, 2023
1 parent 730c22f commit 670eecf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Sources/Brave/Frontend/Browser/BrowserViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2441,7 +2441,7 @@ public class BrowserViewController: UIViewController {
topToolbar.locationContainer.alpha = 1
topToolbar.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
header.collapsedBarContainerView.alpha = 1 - topToolbar.locationContainer.alpha
tabsBar.view.subviews.forEach { $0.alpha = topToolbar.locationContainer.alpha }
tabsBar.view.alpha = topToolbar.locationContainer.alpha
toolbar?.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
}
animator.startAnimation()
Expand All @@ -2464,7 +2464,7 @@ public class BrowserViewController: UIViewController {
toolbarBottomConstraint?.update(offset: min(footerHeight, max(0, footerHeight * (1 - progress))))
}
topToolbar.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
tabsBar.view.subviews.forEach { $0.alpha = topToolbar.locationContainer.alpha }
tabsBar.view.alpha = topToolbar.locationContainer.alpha
header.collapsedBarContainerView.alpha = 1 - topToolbar.locationContainer.alpha
toolbar?.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
return
Expand All @@ -2479,7 +2479,7 @@ public class BrowserViewController: UIViewController {
topToolbar.locationContainer.alpha = 0
toolbarBottomConstraint?.update(offset: footerHeight)
}
tabsBar.view.subviews.forEach { $0.alpha = topToolbar.locationContainer.alpha }
tabsBar.view.alpha = topToolbar.locationContainer.alpha
topToolbar.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
header.collapsedBarContainerView.alpha = 1 - topToolbar.locationContainer.alpha
toolbar?.actionButtons.forEach { $0.alpha = topToolbar.locationContainer.alpha }
Expand Down

0 comments on commit 670eecf

Please sign in to comment.