Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes new tab page and promoted content ads should reward users for up to 4 ads per hour and 20 ads per day - 1.29.x #9650

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fixes new tab page and promoted content ads should reward users for up to 4 ads per hour and 20 ads per day - 1.29.x #9650

merged 1 commit into from
Aug 5, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 4, 2021 •
edited by kjozwiak
Loading

Uplift of #9644
Resolves brave/brave-browser#17352

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.29.x - Beta milestone Aug 4, 2021
@tmancey tmancey requested a review from a team August 4, 2021 19:19
@tmancey tmancey self-assigned this Aug 4, 2021
@tmancey tmancey force-pushed the issues/17352-1.29.x branch from 31d7c74 to 426508b Compare August 4, 2021 20:47
@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2021

Restarting iOS due to version control not being pulled due to insufficient space on the device as per https://ci.brave.com/job/pr-brave-browser-issues-17352-1.29.x-ios/2/execution/node/64/log/.

fatal: write error: No space left on device

Restarting macOS due to init failing because target device had insufficient space as per https://ci.brave.com/job/pr-brave-browser-issues-17352-1.29.x-macos/2/execution/node/110/log/.

fatal: write error: No space left on device

kjozwiak
kjozwiak approved these changes Aug 5, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.29.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9644 (comment).

@kjozwiak kjozwiak merged commit 568d5a9 into 1.29.x Aug 5, 2021
@kjozwiak kjozwiak deleted the issues/17352-1.29.x branch August 5, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak