-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedreader: Point to speedreader in settings #9580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
approved these changes
Jul 28, 2021
kkuehlz
force-pushed
the
speedreader_bubble_settings_link
branch
from
July 28, 2021 20:08
b50936c
to
c31f378
Compare
simonhong
reviewed
Jul 28, 2021
@simonhong What do you think about this version? |
simonhong
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍🏼
We have two options here: (1) Point to brave://settings?search=speedreader, which will highlight the Speedreader setting, or (2) or provide a pointer to brave://settings/appearance. I went with the former because it makes the setting a bit easier to identify. There isn't a way to link to a specific setting. Resolves brave/brave-browser#17216
Linking to a search query to highlight the Speedreader setting only works if we us use the localized string presented by the ui. Currently 8 of 47 locales translate this. Fixup for #9580.
Correction from `npm run lint`.
rillian
force-pushed
the
speedreader_bubble_settings_link
branch
from
October 29, 2021 04:18
a554afa
to
50ce4f8
Compare
Rebased to address ci build failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two options here: (1) Point to
brave://settings?search=speedreader, which will highlight the
Speedreader setting, or (2) or provide a pointer to
brave://settings/appearance. I went with the former because it makes the
setting a bit easier to identify. There isn't a way to link to a
specific setting.
Resolves brave/brave-browser#17216
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
With Speedreader enabled:
Repeat the test in a locale where the Settings page localises the name of the setting to something other than 'Speedreader', e.g. start Brave with
LANGUAGE=ca
. Confirm the setting is still highlighted under a different name. Other current options include Amharic, Arabic, Bengali, Farsi, Greek, Kannada, Indonesian, Latvian, Lithuanian, Malay, Norwegian, and Slovenian,