Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speedreader: Point to speedreader in settings #9580

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Jul 28, 2021

We have two options here: (1) Point to
brave://settings?search=speedreader, which will highlight the
Speedreader setting, or (2) or provide a pointer to
brave://settings/appearance. I went with the former because it makes the
setting a bit easier to identify. There isn't a way to link to a
specific setting.

Resolves brave/brave-browser#17216

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

With Speedreader enabled:

  • Visit a page which triggers reader mode, e.g. https://jeremykun.com/2014/02/24/elliptic-curves-as-python-objects/
  • Click on Speedreader icon at the right of the titlebar
  • Click on the "To turn off Speedreader...visit Settings" link in the configuration bubble.
  • Confirm the settings page opens scrolled to where the 'Speedreader' enable toggle is visible.

Repeat the test in a locale where the Settings page localises the name of the setting to something other than 'Speedreader', e.g. start Brave with LANGUAGE=ca. Confirm the setting is still highlighted under a different name. Other current options include Amharic, Arabic, Bengali, Farsi, Greek, Kannada, Indonesian, Latvian, Lithuanian, Malay, Norwegian, and Slovenian,

@kkuehlz kkuehlz force-pushed the speedreader_bubble_settings_link branch from b50936c to c31f378 Compare July 28, 2021 20:08
@kkuehlz kkuehlz closed this Oct 27, 2021
@kkuehlz kkuehlz removed their assignment Oct 27, 2021
@rillian rillian self-assigned this Oct 28, 2021
@rillian rillian reopened this Oct 28, 2021
@rillian rillian requested a review from simonhong October 28, 2021 23:59
@rillian
Copy link
Contributor

rillian commented Oct 28, 2021

@simonhong What do you think about this version?

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

Kevin Kuehler and others added 3 commits October 28, 2021 21:17
We have two options here: (1) Point to
brave://settings?search=speedreader, which will highlight the
Speedreader setting, or (2) or provide a pointer to
brave://settings/appearance. I went with the former because it makes the
setting a bit easier to identify. There isn't a way to link to a
specific setting.

Resolves brave/brave-browser#17216
Linking to a search query to highlight the Speedreader setting
only works if we us use the localized string presented by the
ui. Currently 8 of 47 locales translate this.

Fixup for #9580.
Correction from `npm run lint`.
@rillian rillian force-pushed the speedreader_bubble_settings_link branch from a554afa to 50ce4f8 Compare October 29, 2021 04:18
@rillian
Copy link
Contributor

rillian commented Oct 29, 2021

Rebased to address ci build failures.

@rillian rillian merged commit c649cca into master Oct 29, 2021
@rillian rillian deleted the speedreader_bubble_settings_link branch October 29, 2021 14:56
@rillian rillian added this to the 1.33.x - Nightly milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speedreader settings link points to brave://settings rather than speedreader settings
4 participants