Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move security and privacy settings out of additional menu #9243

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jun 25, 2021

fix brave/brave-browser#16470

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

all brave://settings items should still be present and functional, but they should be re-ordered to this:

Screen Shot 2021-06-24 at 10 50 59 PM

Screen Shot 2021-06-24 at 10 51 16 PM

note: i noticed a crash when clicking additional settings, but it seems unrelated to this PR. https://bravesoftware.slack.com/archives/C7VLGSR55/p1624599889002200

@diracdeltas diracdeltas requested review from petemill and mkarolin June 25, 2021 05:57
@diracdeltas diracdeltas self-assigned this Jun 25, 2021
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move security and privacy higher in brave://settings
2 participants