Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15967: switch protobuf to json in P3A pings. #8974

Closed
wants to merge 1 commit into from
Closed

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented May 31, 2021

Resolves brave/brave-browser#15967

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@porteron
Copy link
Member

@iefremov I tagged you here https://github.com/brave/devops/issues/6070 which blocks this issue.
We'll want to keep both systems running, both JSON and Protobuf. I'm hoping after a couple releases we should be able to remove the protobuf implementation entirely.

std::string base64;
base::Base64Encode(compressed_log_data, &base64);
url_loader_->AttachStringForUpload(base64, "application/base64");
url_loader_->AttachStringForUpload(log_data, "text/plain");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would application/json be better here?

@porteron
Copy link
Member

porteron commented Jan 5, 2022

@rillian @iefremov Any updates here on the PR?

@iefremov
Copy link
Contributor Author

iefremov commented Jan 6, 2022

@porteron the proper one is #11600

@iefremov iefremov closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of protobufs in P3A pings
3 participants