Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config without node #8892

Merged
merged 1 commit into from
May 24, 2021
Merged

Update config without node #8892

merged 1 commit into from
May 24, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented May 21, 2021

Resolves brave/brave-browser#15937

  • Improved regex to meet -rcX nodes
  • Update config without node
  • Register node updater for each instance of ipfs service

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Use browser with 0.7.0 IPFS node
  • Restart it with --use-dev-goupdater-url command line flag to use dev update server
  • Make sure that the browser has downloaded update and after restarts the node would be 0.9.0
  • Make sure that the ipfs things work as expected with 0.9.0 node, need some regression tests for all features, opening ipfs resources, imports etc.

@spylogsster spylogsster force-pushed the update-to-0.9.0 branch 4 times, most recently from 3e1ada2 to d880cbf Compare May 21, 2021 12:28
@spylogsster spylogsster requested a review from bbondy May 21, 2021 12:30
@bbondy bbondy requested review from yrliou and removed request for bbondy May 21, 2021 13:37
@spylogsster spylogsster force-pushed the update-to-0.9.0 branch 8 times, most recently from 25ad583 to aefee92 Compare May 24, 2021 13:20
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou
Copy link
Member

yrliou commented May 24, 2021

There's gn format error in post-init step, please correct it before merging, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go-ipfs repo migration from 0.7.0 to 0.9.0-rc1 is broken
2 participants