Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ad rewards not updated at brave://rewards due to loss of precision - 1.25.x #8850

Merged
merged 1 commit into from
May 25, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 18, 2021

Uplift of #8786
Resolves brave/brave-browser#15801

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team May 18, 2021 18:50
@tmancey tmancey self-assigned this May 18, 2021
@tmancey tmancey added this to the 1.25.x - Beta milestone May 18, 2021
@kjozwiak kjozwiak closed this May 20, 2021
@kjozwiak kjozwiak removed the request for review from a team May 20, 2021 02:05
@kjozwiak kjozwiak reopened this May 20, 2021
@kjozwiak kjozwiak requested a review from a team May 20, 2021 02:06
@kjozwiak kjozwiak assigned tmancey and unassigned kjozwiak May 20, 2021
@kjozwiak
Copy link
Member

post-init failed due to several warning(s) via audit-deps as per https://ci.brave.com/job/pr-brave-browser-issues-15801-1.25.x-post-init/3/execution/node/145/log/. However, this is a known issue and unrelated to this specific PR.

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-issues-15801-1.25.x-linux/3/testReport/. However, this is a known intermittent failure and unrelated to this specific PR.

linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion062WithRewardsEnabled_ForSupportedLocale_ForNewlySupportedLocale_RewardsShouldBeEnabled_AdsShouldBeDisabled
linux / test-browser / BraveAdsBrowserTest/BraveAdsUpgradeBrowserTest.UpgradePath/PreferencesForVersion072WithRewardsAndAdsEnabled_ForSupportedLocale_ForUnsupportedLocale_RewardsShouldBeEnabled_AdsShouldBeEnabled

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8786 (comment).

@kjozwiak kjozwiak merged commit 0b44484 into 1.25.x May 25, 2021
@kjozwiak kjozwiak deleted the issues/15801-1.25.x branch May 25, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants