Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add origin-based permission lifetime support (uplift to 1.24.x) #8585

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Add origin-based permission lifetime support (uplift to 1.24.x) #8585

merged 1 commit into from
Apr 23, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 21, 2021 •
edited by kjozwiak
Loading

Uplift of #8378

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from bridiver and a team as code owners April 21, 2021 06:32
@brave-builds brave-builds requested a review from a team April 21, 2021 06:32
@brave-builds brave-builds self-assigned this Apr 21, 2021
@brave-builds brave-builds added this to the 1.24.x - Beta milestone Apr 21, 2021
@goodov
Copy link
Member

goodov commented Apr 21, 2021 •
edited
Loading

Uplifted changes was tested on nightly here: #8378 (comment)

@goodov goodov mentioned this pull request Apr 22, 2021
Closed
kjozwiak
kjozwiak approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.24.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #8378 (comment).

@kjozwiak kjozwiak merged commit 3d04247 into 1.24.x Apr 23, 2021
@kjozwiak kjozwiak deleted the pr8378_issues/14126-2_1.24.x branch April 23, 2021 15:13
@kjozwiak kjozwiak mentioned this pull request Apr 23, 2021
Closed
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
@Brandon-T
Fix #8585 - Fix Javascript Disabling <NoScript> (#8586)
e35b435 
- Fix Javascript Disabling not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @goodov @kjozwiak @brave-browser-releases