Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onSelectorReturned unit tests #8429

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#15109

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton
Copy link
Member

bsclifton commented Apr 5, 2021

Looks like this has a few failures:

[2021-04-05T01:57:25.048Z] ERROR: /home/ubuntu/workspace/pr-brave-browser-fix-onSelectorReturned-unit-tests-pre-init/components/test/brave_extension/background/events/cosmeticFilterEvents_test.ts:89:13 - Promises must be handled appropriately

[2021-04-05T01:57:25.048Z] ERROR: /home/ubuntu/workspace/pr-brave-browser-fix-onSelectorReturned-unit-tests-pre-init/components/test/brave_extension/background/events/cosmeticFilterEvents_test.ts:96:13 - Promises must be handled appropriately

[2021-04-05T01:57:25.048Z] ERROR: /home/ubuntu/workspace/pr-brave-browser-fix-onSelectorReturned-unit-tests-pre-init/components/test/brave_extension/background/events/cosmeticFilterEvents_test.ts:111:11 - Promises must be handled appropriately

[2021-04-05T01:57:25.048Z] ERROR: /home/ubuntu/workspace/pr-brave-browser-fix-onSelectorReturned-unit-tests-pre-init/components/test/brave_extension/background/events/cosmeticFilterEvents_test.ts:120:11 - Promises must be handled appropriately

[2021-04-05T01:57:25.049Z] ERROR: /home/ubuntu/workspace/pr-brave-browser-fix-onSelectorReturned-unit-tests-pre-init/components/test/brave_extension/background/events/cosmeticFilterEvents_test.ts:125:11 - Promises must be handled appropriately

You should be able to run this locally from inside src/brave using npm run test-unit. Will take a look real quick

@bsclifton bsclifton force-pushed the fix-onSelectorReturned-unit-tests branch from 0dcca3e to 9f9d886 Compare April 5, 2021 06:55
@bsclifton
Copy link
Member

OK I think this just needed a rebase; original branch didn't have b80a029

CI re-running now 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 803521a into master Apr 5, 2021
@bsclifton bsclifton deleted the fix-onSelectorReturned-unit-tests branch April 5, 2021 17:05
@bsclifton bsclifton added this to the 1.24.x - Nightly milestone Apr 5, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing on master after https://github.com/brave/brave-core/pull/8394
2 participants