referrals: stats: Always RETRY_ON_NETWORK_CHANGE #8396

kkuehlz · 2021-03-31T00:19:42Z

Resolves brave/brave-browser#15034

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Go through the entire referral pipeline with @keur. Ensure stats usage pings work as expected.

Resolves brave/brave-browser#15034

kjozwiak · 2021-03-31T17:25:25Z

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.24.38 Chromium: 90.0.4430.41 (Official Build) nightly (64-bit)
-- | --
Revision | e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS | Windows 10 OS Version 2009 (Build 19042.868)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used
@keur confirmed that the referral finalized via server side after moving date ~40 days ahead

Logs/Data from brave://local-state

```      "referral": {
         "download_id": "6d6083b1-07d8-430f-8459-144ff29568b8",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=winx64-bc&channel=nightly&version=1.24.38&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"```

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.24.38 Chromium: 90.0.4430.41

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used
@keur confirmed that the referral finalized via server side after moving date ~40 days ahead

Logs/Data from brave://local-state

"referral": {
         "download_id": "5159a3cb-5ddb-4c09-8e8e-0ae07ccf0c14",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708",
         "referral_attempt_count": 1,
         "referral_attempt_timestamp": "13266434793315790"
      },
      "referral_android_first_run_timestamp": "13261682597806899",
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=android-bc&channel=canary&version=1.24.38&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }

Verification passed on Brave v1.24.38 on Samsung Galaxy Tab S5e (Android 10.0)

1.24.38 Chromium: 90.0.4430.41

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used
@keur confirmed that the referral finalized via server side after moving date ~40 days ahead

Logs/Data from brave://local-state

referral": { "download_id": "6e11cc54-d1f1-43d3-8f3e-a5a69b71928d", "headers": [ { "cookieNames": [ ], "domains": [ "eaff.com", "stg.eaff.com" ], "expiration": 31536000000.0, "headers": { "X-Brave-Partner": "eaff" } }, { "cookieNames": [ ], "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ], "expiration": 31536000000.0, "headers": { "X-Brave-Partner": "uphold" } } ], "initialization": true, "promo_code": "WWK708" },

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.24.38 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
-- | --
Revision | e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS | macOS Version 10.15.7 (Build 19H524)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used
@keur confirmed that the referral finalized via server side after moving date ~40 days ahead

Logs/Data from brave://local-state

referral": {
         "download_id": "07426b87-db05-4f14-80ac-6b7d15bf32f8",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=osx-bc&channel=nightly&version=1.24.38&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      },

Verification PASSED on Asus Zenfone (x86) running Android 6 using the following build:

1.24.38 Chromium: 90.0.4430.41

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used
@keur confirmed that the referral finalized via server side after moving date ~40 days ahead

Logs/Data from brave://local-state

"referral": {
         "download_id": "c41ae6b7-12eb-4dbe-9007-b30a8558986c",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
      },
      "referral_android_first_run_timestamp": "13261683151793210",
      "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_query": "https://laptop-updates.brave.com/1/usage/brave-core-threshold?platform=android-bc&channel=canary&version=1.24.38&daily=true&weekly=true&monthly=true&first=true&woi=2021-03-29&dtoi=2021-03-31&ref=WWK708&adsEnabled=false&arch=",
         "week_of_installation": "2021-03-29"
      }

Verification PASSED using nightly build on macOS Big Sur (11.2.3)

Brave	1.24.38 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
Revision	e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS	macOS Version 11.2.3 (Build 20D91)

ensured that download_id appears under brave://local-state
ensured that the headers are appearing under brave://local-state
ensured that stats are appearing under brave://local-state
ensure that "promo_code": "WWK708" is correctly being used

Logs/Data from brave://local-state

"referral": {
         "download_id": "31cf162d-6cff-4c8e-b6d7-a9a854ce1025",
         "headers": [ {
            "cookieNames": [  ],
            "domains": [ "eaff.com", "stg.eaff.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "eaff"
            }
         }, {
            "cookieNames": [  ],
            "domains": [ "sandbox.uphold.com", "api-sandbox.uphold.com", "uphold.com", "api.uphold.com" ],
            "expiration": 31536000000.0,
            "headers": {
               "X-Brave-Partner": "uphold"
            }
         } ],
         "initialization": true,
         "promo_code": "WWK708"
 "stats": {
         "first_check_made": true,
         "last_check_month": 3,
         "last_check_woy": 13,
         "last_check_ymd": "2021-03-31",
         "threshold_check_made": true,
         "week_of_installation": "2021-03-29"
      },

kkuehlz requested a review from simonhong as a code owner March 31, 2021 00:19

kkuehlz self-assigned this Mar 31, 2021

kkuehlz requested review from yachtcaptain23 and bridiver March 31, 2021 00:24

referrals: stats: Always RETRY_ON_NETWORK_CHANGE

2fd5f2e

Resolves brave/brave-browser#15034

kkuehlz force-pushed the referrals_retry_net_change branch from b776573 to 2fd5f2e Compare March 31, 2021 02:23

kkuehlz changed the title ~~referrals: Always RETRY_ON_NETWORK_CHANGE~~ referrals: stats: Always RETRY_ON_NETWORK_CHANGE Mar 31, 2021

kkuehlz requested a review from emerick March 31, 2021 02:28

yachtcaptain23 approved these changes Mar 31, 2021

View reviewed changes

simonhong approved these changes Mar 31, 2021

View reviewed changes

kkuehlz merged commit e263cbb into master Mar 31, 2021

kkuehlz deleted the referrals_retry_net_change branch March 31, 2021 05:19

This was referenced Mar 31, 2021

Retry referral ping if the referral ping has an error on retry. (uplift to 1.23.x) #8388

Merged

Retry referral ping if the referral ping has an error on retry. (uplift to 1.22.x) #8387

Merged

kjozwiak mentioned this pull request Mar 31, 2021

Retry referral ping if the first referral ping has an error. #8382

Merged

24 tasks

kjozwiak added this to the 1.24.x - Nightly milestone Mar 31, 2021

kylehickinson added a commit that referenced this pull request Jan 4, 2024

Fix #8396: Use correct text color for Brave VPN menu button (#8427)

56653e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

referrals: stats: Always RETRY_ON_NETWORK_CHANGE #8396

referrals: stats: Always RETRY_ON_NETWORK_CHANGE #8396

kkuehlz commented Mar 31, 2021 •

edited

Loading

kjozwiak commented Mar 31, 2021 •

edited by stephendonner

Loading

referrals: stats: Always RETRY_ON_NETWORK_CHANGE #8396

referrals: stats: Always RETRY_ON_NETWORK_CHANGE #8396

Conversation

kkuehlz commented Mar 31, 2021 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

kjozwiak commented Mar 31, 2021 • edited by stephendonner Loading

kkuehlz commented Mar 31, 2021 •

edited

Loading

kjozwiak commented Mar 31, 2021 •

edited by stephendonner

Loading