-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedreader: Add --speedreader-backend switch #8363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, thanks for clarifying. Could you change the names to something more descriptive then?
Maybe list, classify (and if there is such an option, list-and-classify)?
Done. Since we only have two backends right now, any option that isn't |
great, thanks! LGTM! |
d55b7c6
to
e63c6fe
Compare
iOS failing for python reasons, CI passes on macOS, didn't touch anything in |
Resolves brave/brave-browser#14959
This is so @pes10k and @rebron can test the changes we make on nightly. Not particularly relevant until #8349 is merged because the current heuristics backend in master is very incomplete.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on