Add missing call to brave::SetSafeBrowsingEndpointForTesting(true) #8346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingFileCheckURL
was not calling this testing-specific helper at the beginning of its
scope like other SafeBrowsing-related tests from the same test suite,
so the "test.safebrowsing.com" endpoint was not being used unless those
other tests were run before, causing ModifySafeBrowsingFileCheckURL to
fail otherwise.
This patch adds a call brave::SetSafeBrowsingEndpointForTesting(true)
therefore to make sure the test can correctly run regardless of what
other tests have been run prior to it.
Resolves brave/brave-browser#14925
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Run the previously failing testing test and check it passes: