Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing call to brave::SetSafeBrowsingEndpointForTesting(true) #8346

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

mariospr
Copy link
Contributor

BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingFileCheckURL
was not calling this testing-specific helper at the beginning of its
scope like other SafeBrowsing-related tests from the same test suite,
so the "test.safebrowsing.com" endpoint was not being used unless those
other tests were run before, causing ModifySafeBrowsingFileCheckURL to
fail otherwise.

This patch adds a call brave::SetSafeBrowsingEndpointForTesting(true)
therefore to make sure the test can correctly run regardless of what
other tests have been run prior to it.

Resolves brave/brave-browser#14925

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Run the previously failing testing test and check it passes:

testing/xvfb.py npm run test brave_unit_tests -- \
    --filter=BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingFileCheckURL.

BraveStaticRedirectNetworkDelegateHelperTest.ModifySafeBrowsingFileCheckURL
was not calling this testing-specific helper at the beginning of its
scope like other SafeBrowsing-related tests from the same test suite,
so the "test.safebrowsing.com" endpoint was not being used unless those
other tests were run before, causing ModifySafeBrowsingFileCheckURL to
fail otherwise.

This patch adds a call brave::SetSafeBrowsingEndpointForTesting(true)
therefore to make sure the test can correctly run regardless of what
other tests have been run prior to it.

Resolves brave/brave-browser#14925
@mariospr mariospr added this to the 1.24.x - Nightly milestone Mar 24, 2021
@mariospr mariospr requested a review from iefremov as a code owner March 24, 2021 15:52
@mariospr mariospr self-assigned this Mar 24, 2021
@mariospr
Copy link
Contributor Author

@iefremov Please review this small patch when you have a moment (it's already applied on the cr91 branch), thanks!

@mariospr mariospr merged commit 73e63b5 into master Apr 5, 2021
@mariospr mariospr deleted the issues/14925 branch April 5, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModifySafeBrowsingFileCheckURL unit test fails when running alone
2 participants