Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hardcoded catalog version to use a const #8244

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Mar 13, 2021

Resolves brave/brave-browser#14687

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm catalog is parsed (see console log)

Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@tmancey tmancey force-pushed the issues/14687 branch 2 times, most recently from 8678578 to 301de6a Compare March 16, 2021 09:56
@tmancey
Copy link
Collaborator Author

tmancey commented Mar 16, 2021

CI failed due to know audit deps

@tmancey tmancey merged commit 27d8468 into master Mar 16, 2021
@tmancey tmancey deleted the issues/14687 branch March 16, 2021 14:49
@tmancey tmancey added this to the 1.23.x - Nightly milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor hardcoded catalog version to use a const
2 participants