Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax to assign variable before use #822

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Fix syntax to assign variable before use #822

merged 1 commit into from
Nov 7, 2018

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Nov 7, 2018

Fixes brave/brave-browser#2022

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi requested a review from mihaiplesa November 7, 2018 04:32
mihaiplesa
mihaiplesa approved these changes Nov 7, 2018
View reviewed changes
Copy link
Collaborator

@mihaiplesa mihaiplesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mbacchi mbacchi merged commit db35ae0 into master Nov 7, 2018
@bsclifton bsclifton deleted the issue_2022 branch November 7, 2018 16:29
bsclifton pushed a commit that referenced this pull request Nov 7, 2018
@mbacchi @bsclifton
Merge pull request #822 from brave/issue_2022
94f5bf4 
Fix syntax to assign variable before use
bsclifton pushed a commit that referenced this pull request Nov 7, 2018
@mbacchi @bsclifton
Merge pull request #822 from brave/issue_2022
d123803 
Fix syntax to assign variable before use
@bsclifton
Copy link
Member

bsclifton commented Nov 7, 2018 •
edited
Loading

master db35ae0
0.58.x 94f5bf4
0.57.x d123803
tagged with uplift request for 0.56.x

I set milestone for brave/brave-browser#2022 to be 0.57.x until someone approves this for 0.56.x. If approved, let's be sure to merge + then adjust milestone. Thanks 😄

@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2018

Approved to uplift to 0.56.x after deliberating with @srirambv & @rebron 👍

mbacchi added a commit that referenced this pull request Nov 7, 2018
@mbacchi
Merge pull request #822 from brave/issue_2022
1333361 
Fix syntax to assign variable before use
@mbacchi
Copy link
Contributor Author

mbacchi commented Nov 7, 2018

0.56.x: 1333361

@bbondy bbondy added this to the 0.56.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaiplesa mihaiplesa mihaiplesa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.56.x - Release
Development

Successfully merging this pull request may close these issues.

Fix UnboundLocalError on upload.py
5 participants
@mbacchi @bsclifton @kjozwiak @mihaiplesa @bbondy