-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installation progress to brave://ipfs page #8219
Conversation
f1282c3
to
6c834b3
Compare
|
||
friend class speech::SodaInstallerImpl; | ||
friend class ::ComponentsHandler; | ||
+ BRAVE_COMPONENT_UPDATER_SERVICE_H_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkarolin could you please check my changes to patches, I renamed old macros to meet the class name because I need to create another one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spylogsster this one is fine, the other one I would probably go with BRAVE_COMPONENT_UPDATER_SERVICE_H_ON_DEMAND_UPDATER, or just BRAVE_ON_DEMAND_UPDATER, otherwise it looks like it's in a wrong file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
3b35e8f
to
f5e27e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
and patches
changes LGTM
f5e27e4
to
97df40a
Compare
Resolves brave/brave-browser#13170
Added node installation progress to ipfs diagnostic page
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: